From: Byoungtae Cho <bt.cho@samsung.com>
Adds two watchdog devices for ExynosAutoV920 SoC.
Signed-off-by: Byoungtae Cho <bt.cho@samsung.com>
Signed-off-by: Taewan Kim <trunixs.kim@samsung.com>
---
.../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
index 91882b37fdb3..2b3e8debda3d 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
@@ -172,6 +172,26 @@ chipid@10000000 {
reg = <0x10000000 0x24>;
};
+ watchdog_cl0: watchdog@10060000 {
+ compatible = "samsung,exynosautov920-wdt";
+ reg = <0x10060000 0x100>;
+ interrupts = <GIC_SPI 953 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&xtcxo>, <&xtcxo>;
+ clock-names = "watchdog", "watchdog_src";
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,cluster-index = <0>;
+ };
+
+ watchdog_cl1: watchdog@10070000 {
+ compatible = "samsung,exynosautov920-wdt";
+ reg = <0x10070000 0x100>;
+ interrupts = <GIC_SPI 952 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&xtcxo>, <&xtcxo>;
+ clock-names = "watchdog", "watchdog_src";
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,cluster-index = <1>;
+ };
+
gic: interrupt-controller@10400000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
--
2.47.0On 21/10/2024 08:39, Taewan Kim wrote: > From: Byoungtae Cho <bt.cho@samsung.com> > > Adds two watchdog devices for ExynosAutoV920 SoC. > > Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > --- > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) How did this happen that this patch was taken to watchdog? There is no Ack here from me. Drop this patch from watchdog, I do no agree to take it via that tree. Best regards, Krzysztof
Hi Krzystof, > On 21/10/2024 08:39, Taewan Kim wrote: > > From: Byoungtae Cho <bt.cho@samsung.com> > > > > Adds two watchdog devices for ExynosAutoV920 SoC. > > > > Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > > Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > > --- > > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > How did this happen that this patch was taken to watchdog? There is no > Ack here from me. > > Drop this patch from watchdog, I do no agree to take it via that tree. > > Best regards, > Krzysztof > Seems like you are having a hard day. The 3 patches are dropped. I presume that you will take them all through your tree then? Kind regards, Wim. PS: the patches are: [PATCH v3 1/3] dt-bindings: watchdog: Document ExynosAutoV920 watchdog bindings [PATCH v3 2/3] watchdog: s3c2410_wdt: add support for exynosautov920 SoC [PATCH v3 3/3] arm64: dts: exynosautov920: add watchdog DT node
On 07/11/2024 11:33, Wim Van Sebroeck wrote: > Hi Krzystof, > >> On 21/10/2024 08:39, Taewan Kim wrote: >>> From: Byoungtae Cho <bt.cho@samsung.com> >>> >>> Adds two watchdog devices for ExynosAutoV920 SoC. >>> >>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> >>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> >>> --- >>> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >> >> How did this happen that this patch was taken to watchdog? There is no >> Ack here from me. >> >> Drop this patch from watchdog, I do no agree to take it via that tree. >> >> Best regards, >> Krzysztof >> > > Seems like you are having a hard day. > The 3 patches are dropped. I presume that you will take them all through your tree then? I meant only this one patch, not entire patchset. The bindings and watchdog driver are for you. I commented only about this patch here - DTS. Best regards, Krzysztof
Hi Krzystof, > On 07/11/2024 11:33, Wim Van Sebroeck wrote: > > Hi Krzystof, > > > >> On 21/10/2024 08:39, Taewan Kim wrote: > >>> From: Byoungtae Cho <bt.cho@samsung.com> > >>> > >>> Adds two watchdog devices for ExynosAutoV920 SoC. > >>> > >>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > >>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > >>> --- > >>> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ > >>> 1 file changed, 20 insertions(+) > >> > >> How did this happen that this patch was taken to watchdog? There is no > >> Ack here from me. > >> > >> Drop this patch from watchdog, I do no agree to take it via that tree. > >> > >> Best regards, > >> Krzysztof > >> > > > > Seems like you are having a hard day. > > The 3 patches are dropped. I presume that you will take them all through your tree then? > > I meant only this one patch, not entire patchset. The bindings and > watchdog driver are for you. I commented only about this patch here - DTS. > > > Best regards, > Krzysztof > I added the first two patches again. Even when it sounds more logical to me to keep the 3 together. But that's a never ending discussion, so we won't go into that :-). Kind regards, Wim.
On 07/11/2024 12:33, Wim Van Sebroeck wrote: >>> Seems like you are having a hard day. >>> The 3 patches are dropped. I presume that you will take them all through your tree then? >> >> I meant only this one patch, not entire patchset. The bindings and >> watchdog driver are for you. I commented only about this patch here - DTS. >> >> >> Best regards, >> Krzysztof >> > > I added the first two patches again. Even when it sounds more logical to me to keep the 3 together. Thank you. > But that's a never ending discussion, so we won't go into that :-). DTS is hardware description independent from Linux, therefore always goes separate way than Linux drivers. Best regards, Krzysztof
© 2016 - 2024 Red Hat, Inc.