[PATCH] drm/panel: s6e3ha8: add static modifier to supply list

Dzmitry Sankouski posted 1 patch 1 month ago
drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/panel: s6e3ha8: add static modifier to supply list
Posted by Dzmitry Sankouski 1 month ago
Add 'static' modifier to panel supply list.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410160810.0jaNgxB2-lkp@intel.com/
Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Fix kernel robot static analyzer error.
Rebuild with sparse to be sure.
---
 drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
index 76b5a6ea610d..64c6f7d45bed 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
@@ -24,7 +24,7 @@ struct s6e3ha8 {
 	struct regulator_bulk_data *supplies;
 };
 
-const struct regulator_bulk_data s6e3ha8_supplies[] = {
+static const struct regulator_bulk_data s6e3ha8_supplies[] = {
 	{ .supply = "vdd3" },
 	{ .supply = "vci" },
 	{ .supply = "vddr" },

---
base-commit: 63b3ff03d91ae8f875fe8747c781a521f78cde17
change-id: 20241021-starqltechn_upstream_integration_panel_fix-32270575b583

Best regards,
-- 
Dzmitry Sankouski <dsankouski@gmail.com>
Re: [PATCH] drm/panel: s6e3ha8: add static modifier to supply list
Posted by Neil Armstrong 1 month ago
Hi,

On Mon, 21 Oct 2024 16:52:36 +0300, Dzmitry Sankouski wrote:
> Add 'static' modifier to panel supply list.
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: s6e3ha8: add static modifier to supply list
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91e21479c81dd4e9e22a78d7446f92f6b96a7284

-- 
Neil
Re: [PATCH] drm/panel: s6e3ha8: add static modifier to supply list
Posted by Neil Armstrong 1 month ago
On 21/10/2024 15:52, Dzmitry Sankouski wrote:
> Add 'static' modifier to panel supply list.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410160810.0jaNgxB2-lkp@intel.com/
> Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Fix kernel robot static analyzer error.
> Rebuild with sparse to be sure.
> ---
>   drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
> index 76b5a6ea610d..64c6f7d45bed 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
> @@ -24,7 +24,7 @@ struct s6e3ha8 {
>   	struct regulator_bulk_data *supplies;
>   };
>   
> -const struct regulator_bulk_data s6e3ha8_supplies[] = {
> +static const struct regulator_bulk_data s6e3ha8_supplies[] = {
>   	{ .supply = "vdd3" },
>   	{ .supply = "vci" },
>   	{ .supply = "vddr" },
> 
> ---
> base-commit: 63b3ff03d91ae8f875fe8747c781a521f78cde17
> change-id: 20241021-starqltechn_upstream_integration_panel_fix-32270575b583
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>