The following patches are not related to each other.

- Patch 1: Avoid sending advertisements on stale subflows, reducing
  risks on loosing them.

- Patch 2: Annotate data-races around subflow->fully_established, using
  READ/WRITE_ONCE().

- Patch 3: A small clean-up on the PM side, avoiding a bit of duplicated
  code.

- Patch 4: Use "Middlebox interference" MP_TCPRST code in reaction to a
  packet received without MPTCP options in the middle of a connection.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Davide Caratti (1):
      mptcp: use "middlebox interference" RST when no DSS

Gang Yan (1):
      mptcp: annotate data-races around subflow->fully_established

Geliang Tang (1):
      mptcp: implement mptcp_pm_connection_closed

Matthieu Baerts (NGI0) (1):
      mptcp: pm: send ACK on non-stale subflows

 net/mptcp/diag.c       |  2 +-
 net/mptcp/options.c    |  4 ++--
 net/mptcp/pm.c         |  3 +++
 net/mptcp/pm_netlink.c | 14 +++++++++++---
 net/mptcp/protocol.c   |  8 +++-----
 net/mptcp/protocol.h   |  6 +++---
 net/mptcp/subflow.c    | 16 ++++++++++------
 7 files changed, 33 insertions(+), 20 deletions(-)
---
base-commit: 7cb08476e19fb3d0dce618df7c11713434553e27
change-id: 20241018-net-next-mptcp-misc-6-13-c34335423ea0

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

On Mon, 21 Oct 2024 17:14:02 +0200 Matthieu Baerts (NGI0) wrote:
> The following patches are not related to each other.
> 
> - Patch 1: Avoid sending advertisements on stale subflows, reducing
>   risks on loosing them.
> 
> - Patch 2: Annotate data-races around subflow->fully_established, using
>   READ/WRITE_ONCE().
> 
> - Patch 3: A small clean-up on the PM side, avoiding a bit of duplicated
>   code.
> 
> - Patch 4: Use "Middlebox interference" MP_TCPRST code in reaction to a
>   packet received without MPTCP options in the middle of a connection.

Could be a coincidence but looks like we got two flakes in mptcp-join
since yesterday (different sub-cases). What's more sad is that it looks
like our subcase parsing is broken, when I look at the subcase view
all sub-cases are marked as passing :( Could you take a look?

Hi Jakub,

On 30/10/2024 00:50, Jakub Kicinski wrote:
> On Mon, 21 Oct 2024 17:14:02 +0200 Matthieu Baerts (NGI0) wrote:
>> The following patches are not related to each other.
>>
>> - Patch 1: Avoid sending advertisements on stale subflows, reducing
>>   risks on loosing them.
>>
>> - Patch 2: Annotate data-races around subflow->fully_established, using
>>   READ/WRITE_ONCE().
>>
>> - Patch 3: A small clean-up on the PM side, avoiding a bit of duplicated
>>   code.
>>
>> - Patch 4: Use "Middlebox interference" MP_TCPRST code in reaction to a
>>   packet received without MPTCP options in the middle of a connection.
> 
> Could be a coincidence but looks like we got two flakes in mptcp-join
> since yesterday (different sub-cases).

Thank you for having reported this. It looks like a coincidence, but I
will monitor that.

> What's more sad is that it looks
> like our subcase parsing is broken, when I look at the subcase view
> all sub-cases are marked as passing :( Could you take a look?

I think the issue is with the 'retry' feature, when the nested tests are
parsed. I hope I fixed this in:

  https://github.com/linux-netdev/nipa/pull/43

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.