Add dedicated samsung,exynos8895-uart compatible to the dt-schema for
representing uart of the Exynos8895 SoC.
Like GS101, it has a required DT property samsung,uart-fifosize, but
it does not exhibit the 32 bit register access limit.
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
.../bindings/serial/samsung_uart.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 788c80e47..2491b6048 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -27,6 +27,7 @@ properties:
- samsung,exynos4210-uart
- samsung,exynos5433-uart
- samsung,exynos850-uart
+ - samsung,exynos8895-uart
- items:
- enum:
- samsung,exynos7-uart
@@ -172,6 +173,22 @@ allOf:
clock-names:
maxItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynos8895-uart
+ then:
+ required:
+ - samsung,uart-fifosize
+ properties:
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ maxItems: 2
+
unevaluatedProperties: false
examples:
--
2.43.0On 20/10/2024 20:02, Ivaylo Ivanov wrote: > Add dedicated samsung,exynos8895-uart compatible to the dt-schema for > representing uart of the Exynos8895 SoC. > > Like GS101, it has a required DT property samsung,uart-fifosize, but > it does not exhibit the 32 bit register access limit. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > .../bindings/serial/samsung_uart.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > index 788c80e47..2491b6048 100644 > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > @@ -27,6 +27,7 @@ properties: > - samsung,exynos4210-uart > - samsung,exynos5433-uart > - samsung,exynos850-uart > + - samsung,exynos8895-uart > - items: > - enum: > - samsung,exynos7-uart > @@ -172,6 +173,22 @@ allOf: > clock-names: > maxItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynos8895-uart This looks exactly like gs101, so please grow the enum there. Best regards, Krzysztof
On 10/21/24 12:29, Krzysztof Kozlowski wrote: > On 20/10/2024 20:02, Ivaylo Ivanov wrote: >> Add dedicated samsung,exynos8895-uart compatible to the dt-schema for >> representing uart of the Exynos8895 SoC. >> >> Like GS101, it has a required DT property samsung,uart-fifosize, but >> it does not exhibit the 32 bit register access limit. >> >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> >> --- >> .../bindings/serial/samsung_uart.yaml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> index 788c80e47..2491b6048 100644 >> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> @@ -27,6 +27,7 @@ properties: >> - samsung,exynos4210-uart >> - samsung,exynos5433-uart >> - samsung,exynos850-uart >> + - samsung,exynos8895-uart >> - items: >> - enum: >> - samsung,exynos7-uart >> @@ -172,6 +173,22 @@ allOf: >> clock-names: >> maxItems: 2 >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - samsung,exynos8895-uart > This looks exactly like gs101, so please grow the enum there. It's missing the reg-io-width property. My initial idea was to add a completely new entry, so new exynos platforms that don't exhibit the same issue could grow the enum there. Although now that I think about it, I could grow the gs101 enum and set the reg-io-width property for gs101 after that list. Best regards, Ivo. > Best regards, > Krzysztof >
© 2016 - 2024 Red Hat, Inc.