[PATCH] bcachefs: Use str_write_read() helper in ec_block_endio()

Thorsten Blum posted 1 patch 1 month ago
fs/bcachefs/ec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] bcachefs: Use str_write_read() helper in ec_block_endio()
Posted by Thorsten Blum 1 month ago
Remove hard-coded strings by using the helper function str_write_read().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/bcachefs/ec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/bcachefs/ec.c b/fs/bcachefs/ec.c
index e410cfe37b1a..26b1664adb4d 100644
--- a/fs/bcachefs/ec.c
+++ b/fs/bcachefs/ec.c
@@ -26,6 +26,7 @@
 #include "util.h"
 
 #include <linux/sort.h>
+#include <linux/string_choices.h>
 
 #ifdef __KERNEL__
 
@@ -732,7 +733,7 @@ static void ec_block_endio(struct bio *bio)
 			       ? BCH_MEMBER_ERROR_write
 			       : BCH_MEMBER_ERROR_read,
 			       "erasure coding %s error: %s",
-			       bio_data_dir(bio) ? "write" : "read",
+			       str_write_read(bio_data_dir(bio)),
 			       bch2_blk_status_to_str(bio->bi_status)))
 		clear_bit(ec_bio->idx, ec_bio->buf->valid);
 
-- 
2.47.0
Re: [PATCH] bcachefs: Use str_write_read() helper in ec_block_endio()
Posted by Kent Overstreet 1 month ago
On Sun, Oct 20, 2024 at 01:20:46PM +0200, Thorsten Blum wrote:
> Remove hard-coded strings by using the helper function str_write_read().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Applied