net: sched: etf: Use str_on_off() helper function in etf_init()

[PATCH net-next] net: sched: etf: Use str_on_off() helper function in etf_init()

Posted by Thorsten Blum 1 year, 3 months ago

Remove hard-coded strings by using the helper function str_on_off().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 net/sched/sch_etf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c
index c74d778c32a1..c62730f5df4c 100644
--- a/net/sched/sch_etf.c
+++ b/net/sched/sch_etf.c
@@ -369,8 +369,8 @@ static int etf_init(struct Qdisc *sch, struct nlattr *opt,
 
 	pr_debug("delta %d clockid %d offload %s deadline %s\n",
 		 qopt->delta, qopt->clockid,
-		 OFFLOAD_IS_ON(qopt) ? "on" : "off",
-		 DEADLINE_MODE_IS_ON(qopt) ? "on" : "off");
+		 str_on_off(OFFLOAD_IS_ON(qopt)),
+		 str_on_off(DEADLINE_MODE_IS_ON(qopt)));
 
 	err = validate_input_params(qopt, extack);
 	if (err < 0)
-- 
2.47.0

Re: [PATCH net-next] net: sched: etf: Use str_on_off() helper function in etf_init()

Posted by Jakub Kicinski 1 year, 3 months ago

On Sun, 20 Oct 2024 12:47:59 +0200 Thorsten Blum wrote:
> Remove hard-coded strings by using the helper function str_on_off().

Use of the common string helpers is a bit subjective.
Let's leave this code be.
-- 
pw-bot: reject

Re: [PATCH net-next] net: sched: etf: Use str_on_off() helper function in etf_init()

Posted by Vinicius Costa Gomes 1 year, 3 months ago

Thorsten Blum <thorsten.blum@linux.dev> writes:

> Remove hard-coded strings by using the helper function str_on_off().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---

Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>


Cheers,
-- 
Vinicius