Since the initial support for the RK3588 HDMI TX Controller [1] has been
merged as of next-20241018, let's enable the HDMI0 output port for the
following boards: Radxa ROCK 5A & 5B, Rockchip RK3588 EVB1 V10, Xunlong
Orange Pi 5+.

@Luis: Could you please verify this series still works as expected on
your Orange Pi device?

Thanks,
Cristian

[1]: https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Changes in v2:
- Updated descriptions for rock-5a & rock-5b patches to include Radxa,
  per Naoki's review; also collected his Tested-by on the latter
- Included Naoki's HPD pin related fix in rock-5a patch and dropped the
  UNTESTED prefix from the subject
- Link to v1: https://lore.kernel.org/r/20241019-rk3588-hdmi0-dt-v1-0-bd8f299feacd@collabora.com

---
Cristian Ciocaltea (5):
      arm64: dts: rockchip: Add HDMI0 node to rk3588
      arm64: dts: rockchip: Enable HDMI0 on rock-5b
      arm64: dts: rockchip: Enable HDMI0 on rk3588-evb1
      arm64: dts: rockchip: Enable HDMI0 on orangepi-5-plus
      arm64: dts: rockchip: Enable HDMI0 on rock-5a

 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 41 +++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts   | 47 +++++++++++++++++++
 .../boot/dts/rockchip/rk3588-orangepi-5-plus.dts   | 47 +++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts    | 47 +++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts   | 52 ++++++++++++++++++++++
 5 files changed, 234 insertions(+)
---
base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
change-id: 20241018-rk3588-hdmi0-dt-1a135d0076af

W dniu 19.10.2024 o 12:12, Cristian Ciocaltea pisze:
> Since the initial support for the RK3588 HDMI TX Controller [1] has been
> merged as of next-20241018, let's enable the HDMI0 output port for the
> following boards: Radxa ROCK 5A & 5B, Rockchip RK3588 EVB1 V10, Xunlong
> Orange Pi 5+.

I copied changes to FriendlyELEC NanoPC-T6 DT and booted 6.12-rc3 with 
your changes on LTS variant of the board.

With my SBC monitor it complained about resolution (10.5" 1366x768px):

rockchip-drm display-subsystem: [drm] *ERROR* vp0 Cluster0-win0 
actual_w[1366] not 4 pixel aligned

And monitor told me "no signal".

/sys/devices/platform/display-subsystem/drm/card1/card1-HDMI-A-1/modes 
lists all resolutions available.

Would be nice to see system going to next EDID resolution in such case. 
1280x720px is 4px aligned.


With my 34" 3440x1440px monitor it shown some output once. In resolution 
close to original one but 16:9 instead of 21:9 one. Anyway monitor 
behaved in "I do not like that signal" way - started blinking, had 
problems with displaying even from my desktop after.


I got a feeling that 1920x1080px monitor landed on my "need to buy" list.

On 10/22/24 7:29 PM, Marcin Juszkiewicz wrote:
> W dniu 19.10.2024 o 12:12, Cristian Ciocaltea pisze:
>> Since the initial support for the RK3588 HDMI TX Controller [1] has been
>> merged as of next-20241018, let's enable the HDMI0 output port for the
>> following boards: Radxa ROCK 5A & 5B, Rockchip RK3588 EVB1 V10, Xunlong
>> Orange Pi 5+.
> 
> I copied changes to FriendlyELEC NanoPC-T6 DT and booted 6.12-rc3 with
> your changes on LTS variant of the board.
> 
> With my SBC monitor it complained about resolution (10.5" 1366x768px):
> 
> rockchip-drm display-subsystem: [drm] *ERROR* vp0 Cluster0-win0
> actual_w[1366] not 4 pixel aligned
> 
> And monitor told me "no signal".
> 
> /sys/devices/platform/display-subsystem/drm/card1/card1-HDMI-A-1/modes
> lists all resolutions available.
> 
> Would be nice to see system going to next EDID resolution in such case.
> 1280x720px is 4px aligned.
> 
> 
> With my 34" 3440x1440px monitor it shown some output once. In resolution
> close to original one but 16:9 instead of 21:9 one. Anyway monitor
> behaved in "I do not like that signal" way - started blinking, had
> problems with displaying even from my desktop after.
> 
> 
> I got a feeling that 1920x1080px monitor landed on my "need to buy" list.

I'd suggest giving [1] or [2] a try and see if it fixes your display
issues.

The VOP2 support for rk3588 in mainline is not able to properly handle all
display modes advertised by the connected displays. We have a workaround
and I'm currently working on an upstreamable solution.

[1] https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux
[2] https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/tree/rk3588-hdmi-bridge-v6.12-rc2

On Sat Oct 19, 2024 at 12:12 PM CEST, Cristian Ciocaltea wrote:
> Since the initial support for the RK3588 HDMI TX Controller [1] has been
> merged as of next-20241018, let's enable the HDMI0 output port for the
> following boards: Radxa ROCK 5A & 5B, Rockchip RK3588 EVB1 V10, Xunlong
> Orange Pi 5+.

Would the DT changes be the same for the ROCK 5 ITX?
I don't have the board (yet), but apparently some bought it on my
'recommendation' (I only mentioned its existence) and it would be cool
if HDMI out would work for them too.

Cheers,
  Diederik

> [1]: https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/

On Sat, 19 Oct 2024 13:12:09 +0300, Cristian Ciocaltea wrote:
> Since the initial support for the RK3588 HDMI TX Controller [1] has been
> merged as of next-20241018, let's enable the HDMI0 output port for the
> following boards: Radxa ROCK 5A & 5B, Rockchip RK3588 EVB1 V10, Xunlong
> Orange Pi 5+.
> 
> @Luis: Could you please verify this series still works as expected on
> your Orange Pi device?
> 
> [...]

Applied, thanks!

[1/5] arm64: dts: rockchip: Add HDMI0 node to rk3588
      commit: 872c5aea392dc72ffe74eeab2b25864eadc12d23
[2/5] arm64: dts: rockchip: Enable HDMI0 on rock-5b
      commit: 9dee4ce1c35129d9d1971cb840b6af84bc5cba4c
[3/5] arm64: dts: rockchip: Enable HDMI0 on rk3588-evb1
      commit: c56ce5af882ffeb93d52560ad8c6199362698250
[4/5] arm64: dts: rockchip: Enable HDMI0 on orangepi-5-plus
      commit: 76ba840373b9d064eeeab17798990662f5d5eac5

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>