[v1] leds: max5970: fix unreleased fwnode_handle in probe function

[PATCH 0/2] leds: max5970: fix unreleased fwnode_handle in probe function

Javier Carrasco posted 2 patches 1 month, 1 week ago

Diff against v2
Download series mbox

There is a newer version of this series

drivers/leds/leds-max5970.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH 0/2] leds: max5970: fix unreleased fwnode_handle in probe function

Posted by Javier Carrasco 1 month, 1 week ago

This series fixes the wrong management of the 'led_node' fwnode_handle,
which is not released after it is no longer required. This affects both
the normal path of execution and the existing error paths (currently
two) in max5970_led_probe().

First, the missing callst to fwnode_handle_put() in the different code
paths are added, to make the patch available for stable kernels. Then,
the code gets updated to a more robust approach by means of the __free()
macro to automatically release the node when it goes out of scope,
removing the need for explicit calls to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (2):
      leds: max5970: fix unreleased fwnode_handle in probe function
      leds: max5970: use cleanup facility for fwnode_handle led_node

 drivers/leds/leds-max5970.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
change-id: 20241019-max5970-of_node_put-939b004f57d2

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>