[PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump

Dmitry Baryshkov posted 6 patches 1 month, 1 week ago
[PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump
Posted by Dmitry Baryshkov 1 month, 1 week ago
Although the interlace_allowed and ycbcr_420_allowed flags are a part of
the struct drm_connector rather than struct drm_connector_state, still
include them into state dump in order to ease debugging of the setup
issues.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/drm_atomic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 0fc99da93afe..9ea2611770f4 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -1132,6 +1132,8 @@ static void drm_atomic_connector_print_state(struct drm_printer *p,
 	drm_printf(p, "connector[%u]: %s\n", connector->base.id, connector->name);
 	drm_printf(p, "\tcrtc=%s\n", state->crtc ? state->crtc->name : "(null)");
 	drm_printf(p, "\tself_refresh_aware=%d\n", state->self_refresh_aware);
+	drm_printf(p, "\tinterlace_allowed=%d\n", connector->interlace_allowed);
+	drm_printf(p, "\tycbcr_420_allowed=%d\n", connector->ycbcr_420_allowed);
 	drm_printf(p, "\tmax_requested_bpc=%d\n", state->max_requested_bpc);
 	drm_printf(p, "\tcolorspace=%s\n", drm_get_colorspace_name(state->colorspace));
 

-- 
2.39.5
Re: [PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump
Posted by Neil Armstrong 1 month ago
On 18/10/2024 23:49, Dmitry Baryshkov wrote:
> Although the interlace_allowed and ycbcr_420_allowed flags are a part of
> the struct drm_connector rather than struct drm_connector_state, still
> include them into state dump in order to ease debugging of the setup
> issues.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/drm_atomic.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 0fc99da93afe..9ea2611770f4 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -1132,6 +1132,8 @@ static void drm_atomic_connector_print_state(struct drm_printer *p,
>   	drm_printf(p, "connector[%u]: %s\n", connector->base.id, connector->name);
>   	drm_printf(p, "\tcrtc=%s\n", state->crtc ? state->crtc->name : "(null)");
>   	drm_printf(p, "\tself_refresh_aware=%d\n", state->self_refresh_aware);
> +	drm_printf(p, "\tinterlace_allowed=%d\n", connector->interlace_allowed);
> +	drm_printf(p, "\tycbcr_420_allowed=%d\n", connector->ycbcr_420_allowed);
>   	drm_printf(p, "\tmax_requested_bpc=%d\n", state->max_requested_bpc);
>   	drm_printf(p, "\tcolorspace=%s\n", drm_get_colorspace_name(state->colorspace));
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>