[v1] apparmor: Remove unnecessary NULL check before kvfree()

[RESEND PATCH] apparmor: Remove unnecessary NULL check before kvfree()

Thorsten Blum posted 1 patch 1 month, 1 week ago

Diff against v1 v1
Download mbox

There is a newer version of this series

security/apparmor/policy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[RESEND PATCH] apparmor: Remove unnecessary NULL check before kvfree()

Posted by Thorsten Blum 1 month, 1 week ago

Since kvfree() already checks if its argument is NULL, an additional
check before calling kvfree() is unnecessary and can be removed.

Remove it and the following Coccinelle/coccicheck warning reported by
ifnullfree.cocci:

  WARNING: NULL check before some freeing functions is not needed

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 security/apparmor/policy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index 14df15e35695..ce1c96cb2aed 100644
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -103,8 +103,7 @@ static void aa_free_pdb(struct aa_policydb *pdb)
 {
 	if (pdb) {
 		aa_put_dfa(pdb->dfa);
-		if (pdb->perms)
-			kvfree(pdb->perms);
+		kvfree(pdb->perms);
 		aa_free_str_table(&pdb->trans);
 		kfree(pdb);
 	}
-- 
2.47.0