On 10/18/2024 11:18 AM, Denis Kenzior wrote:
> Add a read-only 'endpoint' sysfs entry that contains the qrtr endpoint
> identifier assigned to this mhi device. Can be used to direct / receive
> qrtr traffic only from a particular MHI device.
>
> Signed-off-by: Denis Kenzior <denkenz@gmail.com>
> Reviewed-by: Marcel Holtmann <marcel@holtmann.org>
> Reviewed-by: Andy Gross <agross@kernel.org>
> ---
> net/qrtr/mhi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index 69f53625a049..a4696ed31fb1 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -72,6 +72,16 @@ static int qcom_mhi_qrtr_send(struct qrtr_endpoint *ep, struct sk_buff *skb)
> return rc;
> }
>
> +static ssize_t endpoint_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct qrtr_mhi_dev *qdev = dev_get_drvdata(dev);
> +
> + return sprintf(buf, "%d\n", qdev->ep.id);
%u might be more appropriate because the endpoint id is stored as a u32
> +}
> +
> +static DEVICE_ATTR_RO(endpoint);
> +
> static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> const struct mhi_device_id *id)
> {
> @@ -91,6 +101,9 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> if (rc)
> return rc;
>
> + if (device_create_file(&mhi_dev->dev, &dev_attr_endpoint) < 0)
> + dev_err(qdev->dev, "Failed to create endpoint attribute\n");
> +
> /* start channels */
> rc = mhi_prepare_for_transfer_autoqueue(mhi_dev);
> if (rc) {
> @@ -107,6 +120,7 @@ static void qcom_mhi_qrtr_remove(struct mhi_device *mhi_dev)
> {
> struct qrtr_mhi_dev *qdev = dev_get_drvdata(&mhi_dev->dev);
>
> + device_remove_file(&mhi_dev->dev, &dev_attr_endpoint);
> qrtr_endpoint_unregister(&qdev->ep);
> mhi_unprepare_from_transfer(mhi_dev);
> dev_set_drvdata(&mhi_dev->dev, NULL);