[PATCH] mm: Use str_on_off() helper function in report_meminit()

Thorsten Blum posted 1 patch 1 month, 1 week ago
mm/mm_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] mm: Use str_on_off() helper function in report_meminit()
Posted by Thorsten Blum 1 month, 1 week ago
Remove hard-coded strings by using the helper function str_on_off().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 mm/mm_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index 4ba5607aaf19..253972926183 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -2573,8 +2573,8 @@ static void __init report_meminit(void)
 		stack = "off";
 
 	pr_info("mem auto-init: stack:%s, heap alloc:%s, heap free:%s\n",
-		stack, want_init_on_alloc(GFP_KERNEL) ? "on" : "off",
-		want_init_on_free() ? "on" : "off");
+		stack, str_on_off(want_init_on_alloc(GFP_KERNEL)),
+		str_on_off(want_init_on_free()));
 	if (want_init_on_free())
 		pr_info("mem auto-init: clearing system memory may take some time...\n");
 }
-- 
2.47.0
Re: [PATCH] mm: Use str_on_off() helper function in report_meminit()
Posted by Mike Rapoport 1 month, 1 week ago
On Fri, 18 Oct 2024 12:31:51 +0200, Thorsten Blum wrote:
> Remove hard-coded strings by using the helper function str_on_off().
> 
> 

Applied to for-next branch of memblock.git tree, thanks!

[1/1] mm: Use str_on_off() helper function in report_meminit()
      commit: 4bb21dbb6728fbe6cb7e2f7dc7e5388962c4125b

tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next

--
Sincerely yours,
Mike.
Re: [PATCH] mm: Use str_on_off() helper function in report_meminit()
Posted by Anshuman Khandual 1 month ago

On 10/18/24 21:38, Mike Rapoport wrote:
> On Fri, 18 Oct 2024 12:31:51 +0200, Thorsten Blum wrote:
>> Remove hard-coded strings by using the helper function str_on_off().
>>
>>
> 
> Applied to for-next branch of memblock.git tree, thanks!
> 
> [1/1] mm: Use str_on_off() helper function in report_meminit()
>       commit: 4bb21dbb6728fbe6cb7e2f7dc7e5388962c4125b
> 
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
> branch: for-next

Actually there are multiple such instances which could be converted using these
helpers at once in a single patch rather doing in a piecemeal manner.

https://lore.kernel.org/linux-mm/a11f46f7-29bc-4242-bd8b-d316065607e2@arm.com/