hwmon: (nct6775) update ASUS WMI monitoring list 665-ACE/600M-CL

[PATCH] hwmon: (nct6775) update ASUS WMI monitoring list 665-ACE/600M-CL

Posted by Sarah Maedel 1 year, 3 months ago

Boards such as
* Pro WS 665-ACE
* Pro WS 600M-CL
have got a nct6775 chip, but by default there's no use of it
because of resource conflict with WMI method.

This commit adds such boards to the WMI monitoring list.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
Co-developed-by: Tommy Giesler <tommy.giesler@hetzner.com>
Signed-off-by: Tommy Giesler <tommy.giesler@hetzner.com>
Signed-off-by: Sarah Maedel <sarah.maedel@hetzner-cloud.de>
---
 drivers/hwmon/nct6775-platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index 096f1daa8f2b..1218a3b449a8 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -1350,6 +1350,8 @@ static const char * const asus_msi_boards[] = {
 	"Pro H610M-CT D4",
 	"Pro H610T D4",
 	"Pro Q670M-C",
+	"Pro WS 600M-CL",
+	"Pro WS 665-ACE",
 	"Pro WS W680-ACE",
 	"Pro WS W680-ACE IPMI",
 	"Pro WS W790-ACE",
-- 
2.44.0

Re: [PATCH] hwmon: (nct6775) update ASUS WMI monitoring list 665-ACE/600M-CL

Posted by Guenter Roeck 1 year, 3 months ago

On Fri, Oct 18, 2024 at 09:46:10AM +0200, Sarah Maedel wrote:
> Boards such as
> * Pro WS 665-ACE
> * Pro WS 600M-CL
> have got a nct6775 chip, but by default there's no use of it
> because of resource conflict with WMI method.
> 
> This commit adds such boards to the WMI monitoring list.

Use imperative mood:

"Add those boards ...".

or similar. No need to resend, I'll fix it up, but please keep it in mind
for future patch submissions.

Thanks,
Guenter

> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Co-developed-by: Tommy Giesler <tommy.giesler@hetzner.com>
> Signed-off-by: Tommy Giesler <tommy.giesler@hetzner.com>
> Signed-off-by: Sarah Maedel <sarah.maedel@hetzner-cloud.de>
> ---
>  drivers/hwmon/nct6775-platform.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
> index 096f1daa8f2b..1218a3b449a8 100644
> --- a/drivers/hwmon/nct6775-platform.c
> +++ b/drivers/hwmon/nct6775-platform.c
> @@ -1350,6 +1350,8 @@ static const char * const asus_msi_boards[] = {
>  	"Pro H610M-CT D4",
>  	"Pro H610T D4",
>  	"Pro Q670M-C",
> +	"Pro WS 600M-CL",
> +	"Pro WS 665-ACE",
>  	"Pro WS W680-ACE",
>  	"Pro WS W680-ACE IPMI",
>  	"Pro WS W790-ACE",