[PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers

Yue Haibing posted 4 patches 1 month, 1 week ago
There is a newer version of this series
drivers/net/ethernet/intel/igb/igb_main.c     | 22 +++++++-----------
drivers/net/ethernet/intel/igc/igc_main.c     | 20 ++++++----------
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++++++++-----------
.../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 ++++++++-----------
4 files changed, 34 insertions(+), 54 deletions(-)
[PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers
Posted by Yue Haibing 1 month, 1 week ago
Fixing sparse error in xdp run code by introducing new variable xdp_res
instead of overloading this into the skb pointer as i40e drivers done
in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and
commit ae4393dfd472 ("i40e: fix broken XDP support").

v2: Fix this as i40e drivers done instead of return NULL in xdp run code

Yue Haibing (4):
  igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
  igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
  ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
  ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()

 drivers/net/ethernet/intel/igb/igb_main.c     | 22 +++++++-----------
 drivers/net/ethernet/intel/igc/igc_main.c     | 20 ++++++----------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++++++++-----------
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 ++++++++-----------
 4 files changed, 34 insertions(+), 54 deletions(-)

-- 
2.34.1
RE: [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers
Posted by Keller, Jacob E 1 month, 1 week ago

> -----Original Message-----
> From: Yue Haibing <yuehaibing@huawei.com>
> Sent: Thursday, October 17, 2024 7:38 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; ast@kernel.org; daniel@iogearbox.net;
> hawk@kernel.org; john.fastabend@gmail.com; Fijalkowski, Maciej
> <maciej.fijalkowski@intel.com>; vedang.patel@intel.com; Joseph, Jithu
> <jithu.joseph@intel.com>; andre.guedes@intel.com; horms@kernel.org; Keller,
> Jacob E <jacob.e.keller@intel.com>; sven.auhagen@voleatech.de;
> alexander.h.duyck@intel.com
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bpf@vger.kernel.org; yuehaibing@huawei.com
> Subject: [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers
> 
> Fixing sparse error in xdp run code by introducing new variable xdp_res
> instead of overloading this into the skb pointer as i40e drivers done
> in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and
> commit ae4393dfd472 ("i40e: fix broken XDP support").
> 
> v2: Fix this as i40e drivers done instead of return NULL in xdp run code
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Appreciate taking the time to fix all the cases.

> Yue Haibing (4):
>   igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
>   igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
>   ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
>   ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
> 
>  drivers/net/ethernet/intel/igb/igb_main.c     | 22 +++++++-----------
>  drivers/net/ethernet/intel/igc/igc_main.c     | 20 ++++++----------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++++++++-----------
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 ++++++++-----------
>  4 files changed, 34 insertions(+), 54 deletions(-)
> 
> --
> 2.34.1
>