[PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA

Yoshihiro Furudera posted 1 patch 1 month, 1 week ago
drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA
Posted by Yoshihiro Furudera 1 month, 1 week ago
This patch enables DWAPB I2C controller support on Fujitsu MONAKA.

Signed-off-by: Yoshihiro Furudera <fj5100bi@fujitsu.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 2d0c7348e491..c04af315a4f9 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -351,6 +351,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "AMDI0019", ACCESS_INTR_MASK | ARBITRATION_SEMAPHORE },
 	{ "AMDI0510", 0 },
 	{ "APMC0D0F", 0 },
+	{ "FUJI200B", 0 },
 	{ "HISI02A1", 0 },
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
-- 
2.34.1
Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:
> This patch enables DWAPB I2C controller support on Fujitsu MONAKA.

s/This patch enables/Enable/

Also please give more details:
1) is this ID already present in the wild
   (in the products that one may just go and buy)?
if so, mention the example of the product.

2) provide an excerpt from DSDT for the Device object that uses this _HID.

Otherwise the vendor ID is legit [1] and code wise patch is okay.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[1]: https://uefi.org/ACPI_ID_List?acpi_search=fuji

-- 
With Best Regards,
Andy Shevchenko