[PATCH 1/6] dt-bindings: clock: qcom: Add GPU clocks for QCS8300

Imran Shaik posted 6 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 1/6] dt-bindings: clock: qcom: Add GPU clocks for QCS8300
Posted by Imran Shaik 1 month, 1 week ago
Add support for qcom GPU clock controller bindings for QCS8300 platform.

Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,gpucc.yaml | 1 +
 include/dt-bindings/clock/qcom,sa8775p-gpucc.h          | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
index 0858fd635282..b2b8a1e0297f 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
@@ -27,6 +27,7 @@ description: |
 properties:
   compatible:
     enum:
+      - qcom,qcs8300-gpucc
       - qcom,sdm845-gpucc
       - qcom,sa8775p-gpucc
       - qcom,sc7180-gpucc
diff --git a/include/dt-bindings/clock/qcom,sa8775p-gpucc.h b/include/dt-bindings/clock/qcom,sa8775p-gpucc.h
index a5fd784b1ea2..54eaaf1c4e52 100644
--- a/include/dt-bindings/clock/qcom,sa8775p-gpucc.h
+++ b/include/dt-bindings/clock/qcom,sa8775p-gpucc.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /*
- * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved.
  * Copyright (c) 2023, Linaro Limited
  */
 
@@ -31,6 +31,8 @@
 #define GPU_CC_MEMNOC_GFX_CLK			20
 #define GPU_CC_SLEEP_CLK			21
 #define GPU_CC_XO_CLK_SRC			22
+#define GPU_CC_CX_ACCU_SHIFT_CLK		23
+#define GPU_CC_GX_ACCU_SHIFT_CLK		24
 
 /* GPU_CC resets */
 #define GPUCC_GPU_CC_ACD_BCR			0

-- 
2.25.1
Re: [PATCH 1/6] dt-bindings: clock: qcom: Add GPU clocks for QCS8300
Posted by Krzysztof Kozlowski 1 month ago
On Fri, Oct 18, 2024 at 04:42:29PM +0530, Imran Shaik wrote:
> Add support for qcom GPU clock controller bindings for QCS8300 platform.

Why are you adding defines to SA8775p header? Commit msg should explain
non-obvious contents.

Best regards,
Krzysztof
Re: [PATCH 1/6] dt-bindings: clock: qcom: Add GPU clocks for QCS8300
Posted by Imran Shaik 1 month ago

On 10/21/2024 1:24 PM, Krzysztof Kozlowski wrote:
> On Fri, Oct 18, 2024 at 04:42:29PM +0530, Imran Shaik wrote:
>> Add support for qcom GPU clock controller bindings for QCS8300 platform.
> 
> Why are you adding defines to SA8775p header? Commit msg should explain
> non-obvious contents.
> 

The QCS8300 GPU clock controller is mostly identical to SA8775P, but 
QCS8300 has few additional clocks and minor differences. Hence, re-using 
the SA8775P GPUCC for QCS8300. I will update the commit text with these 
details in next series.

Thanks,
Imran

> Best regards,
> Krzysztof
>