On Sat, Oct 19, 2024 at 4:34 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Several HDMI drivers have common code pice in the .mode_valid function
> that validates RGB / 8bpc rate using the TMDS char rate callbacks.
>
> Move this code piece to the common helper and remove the need to perform
> this check manually. In case of DRM_BRIDGE_OP_HDMI bridges the check can
> be dropped in favour of performing it in drm_bridge_connector.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Makes sense, code looks like a correct substitution, and AFAICT covers
all current in tree drivers.
Whole series is
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> ---
> Dmitry Baryshkov (6):
> drm/display: hdmi: add generic mode_valid helper
> drm/sun4i: use drm_hdmi_connector_mode_valid()
> drm/vc4: use drm_hdmi_connector_mode_valid()
> drm/display: bridge_connector: use drm_bridge_connector_mode_valid()
> drm/bridge: lontium-lt9611: drop TMDS char rate check in mode_valid
> drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate
>
> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 12 +++++-------
> drivers/gpu/drm/display/drm_bridge_connector.c | 16 +++++++++++++++-
> drivers/gpu/drm/display/drm_hdmi_helper.c | 25 +++++++++++++++++++++++++
> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +-----------
> drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +---
> include/drm/display/drm_hdmi_helper.h | 4 ++++
> 7 files changed, 52 insertions(+), 25 deletions(-)
> ---
> base-commit: af44b5b5776cc6ac1891393a37b1424509f07b35
> change-id: 20241018-hdmi-mode-valid-aaec4428501c
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>