nfsd: fix final setattr on delegated timestamps

[PATCH 0/3] nfsd: fix final setattr on delegated timestamps

Posted by Jeff Layton 1 month, 1 week ago

Olga reported seeing a NFS4ERR_INVAL return on the final SETATTR before
a DELEGRETURN to set the timestamps. The first patch fixes that by
simply ensuring they are declared writeable. The second patch fixes a
related bug in the stateid handling in that same SETATTR. The last patch
adds a new tracepoint that I found useful for tracking this down.

It might be best to squash the first two patches into this one:

    f6b1cfab609d nfsd: handle delegated timestamps in SETATTR

The last one should probably go in on its own.

Thanks!

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (3):
      nfsd: add TIME_DELEG_ACCESS and TIME_DELEG_MODIFY to writeable attrs
      nfsd: allow SETATTR to provide a READ deleg for updating time_access
      nfsd: new tracepoint for after op_func in compound processing

 fs/nfsd/nfs4proc.c  |  8 +++++++-
 fs/nfsd/nfs4state.c |  2 +-
 fs/nfsd/nfsd.h      |  5 ++++-
 fs/nfsd/trace.h     | 14 +++++++++++++-
 4 files changed, 25 insertions(+), 4 deletions(-)
---
base-commit: 0f8b1a41842544ec66d328ce4349834d7a823d30
change-id: 20241018-delstid-5114634947de

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/3] nfsd: fix final setattr on delegated timestamps

Posted by cel@kernel.org 1 month, 1 week ago

From: Chuck Lever <chuck.lever@oracle.com>

On Fri, 18 Oct 2024 14:44:58 -0400, Jeff Layton wrote:                                              
> Olga reported seeing a NFS4ERR_INVAL return on the final SETATTR before
> a DELEGRETURN to set the timestamps. The first patch fixes that by
> simply ensuring they are declared writeable. The second patch fixes a
> related bug in the stateid handling in that same SETATTR. The last patch
> adds a new tracepoint that I found useful for tracking this down.
> 
> It might be best to squash the first two patches into this one:
> 
> [...]                                                                        

Applied to nfsd-next for v6.13, thanks!                                                                

[1/3] nfsd: add TIME_DELEG_ACCESS and TIME_DELEG_MODIFY to writeable attrs
      (no commit info)
[2/3] nfsd: allow SETATTR to provide a READ deleg for updating time_access
      (no commit info)
[3/3] nfsd: new tracepoint for after op_func in compound processing
      commit: ba6b3220066fdbd38063230cfc7951b728f15464                                                                      

--                                                                              
Chuck Lever