Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

This device tree adds support for the following:

- SimpleFB
- 8GB RAM
- Buttons

Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
---
 arch/arm64/boot/dts/exynos/Makefile             |  1 +
 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-x1slte.dts

diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
index deb8dc509..783807249 100644
--- a/arch/arm64/boot/dts/exynos/Makefile
+++ b/arch/arm64/boot/dts/exynos/Makefile
@@ -10,5 +10,6 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
 	exynos8895-dreamlte.dtb		\
 	exynos990-c1s.dtb		\
 	exynos990-x1s.dtb		\
+	exynos990-x1slte.dtb		\
 	exynosautov9-sadk.dtb		\
 	exynosautov920-sadk.dtb
diff --git a/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts b/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts
new file mode 100644
index 000000000..9e6a1a060
--- /dev/null
+++ b/arch/arm64/boot/dts/exynos/exynos990-x1slte.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/*
+ * Samsung Galaxy S20 (x1slte/SM-G980F) device tree source
+ *
+ * Copyright (c) 2024, Umer Uddin <umer.uddin@mentallysanemainliners.org>
+ */
+
+/dts-v1/;
+#include "exynos990-hubble-common.dtsi"
+
+/ {
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	model = "Samsung Galaxy S20";
+	compatible = "samsung,x1slte", "samsung,exynos990";
+};
-- 
2.47.0

On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
> Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
> phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
> has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

8 GB RAM, so the memory map should not be the same (and should not be in
DTSI file).

> 
> This device tree adds support for the following:
> 
> - SimpleFB
> - 8GB RAM
> - Buttons

Best regards,
Krzysztof

On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
> > Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
> > phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
> > has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.

> 8 GB RAM, so the memory map should not be the same (and should not be in
> DTSI file).

> >
> > This device tree adds support for the following:
> >
> > - SimpleFB
> > - 8GB RAM
> > - Buttons

Best regards,
Krzysztof

Hi Krzysztof,

Thank you for the review.
All hubble devices actually do
have the first 8GB of RAM mapped the same, I have personally
checked this, by getting fdt dumps from /sys/firmware/fdt
and checking all of the memory nodes.

Best regards,
Umer

On 18/10/2024 08:48, Umer Uddin wrote:
> On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote:
>>> Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F)
>>> phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It
>>> has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage.
> 
>> 8 GB RAM, so the memory map should not be the same (and should not be in
>> DTSI file).
> 
>>>
>>> This device tree adds support for the following:
>>>
>>> - SimpleFB
>>> - 8GB RAM
>>> - Buttons
> 
> Best regards,
> Krzysztof
> 
> Hi Krzysztof,
> 
> Thank you for the review.
> All hubble devices actually do
> have the first 8GB of RAM mapped the same, I have personally
> checked this, by getting fdt dumps from /sys/firmware/fdt
> and checking all of the memory nodes.
> 

What about remaining 4 GB on X1S?

Best regards,
Krzysztof

On Fri, 18 Oct 2024 09:14:01 +0200, Krzysztof Kozlowski wrote:

> What about remaining 4 GB on X1S?

On x1s, the remaining memory is mapped in the device specific dtsi.

Best regards,
Umer

On 18/10/2024 18:20, Umer Uddin wrote:
> On Fri, 18 Oct 2024 09:14:01 +0200, Krzysztof Kozlowski wrote:
> 
>> What about remaining 4 GB on X1S?
> 
> On x1s, the remaining memory is mapped in the device specific dtsi.

Then it proves that this is not correctly placed - not a shared part of
boards. Remove it from DTSI.

Best regards,
Krzysztof