On Thu, Oct 17, 2024 at 05:43:24PM +0100, Umer Uddin wrote:
> Add devicetree bindings for Samsung Galaxy S20 5G
> and Samsung Galaxy S20 board.
>
> Signed-off-by: Umer Uddin <umer.uddin@mentallysanemainliners.org>
> ---
> .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> index d25a17e69..70a915240 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> @@ -234,6 +234,8 @@ properties:
> items:
> - enum:
> - samsung,c1s # Samsung Galaxy Note20 5G (SM-N981B)
> + - samsung,x1s # Samsung Galaxy S20 5G (SM-G981B)
> + - samsung,x1slte # Samsung Galaxy S20 (SM-G980F)
It does not look like you tested the bindings, at least after quick
look. Please run 'make dt_binding_check' (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof