[PATCH -next] fs: Fix build error

Zheng Zucheng posted 1 patch 1 month, 1 week ago
fs/overlayfs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] fs: Fix build error
Posted by Zheng Zucheng 1 month, 1 week ago
The following build error report:
fs/overlayfs/file.c: In function ‘ovl_file_end_write’:
fs/overlayfs/file.c:292:51: error: parameter name omitted
  292 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
      |                                                   ^~~~~~
fs/overlayfs/file.c:292:59: error: parameter name omitted
  292 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
                                                                  ^~~~~~~

Fixes: 291f180e5929 ("fs: pass offset and result to backing_file end_write() callback")
Signed-off-by: Zheng Zucheng <zhengzucheng@huawei.com>
---
 fs/overlayfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 70df61d5e95a..faeac5842694 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -289,7 +289,7 @@ static void ovl_file_modified(struct file *file)
 	ovl_copyattr(file_inode(file));
 }
 
-static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
+static void ovl_file_end_write(struct file *file, loff_t pos, ssize_t ret)
 {
 	ovl_file_modified(file);
 }
-- 
2.34.1

Re: [PATCH -next] fs: Fix build error
Posted by Miklos Szeredi 1 month, 1 week ago
On Thu, 17 Oct 2024 at 08:50, Zheng Zucheng <zhengzucheng@huawei.com> wrote:
>
> The following build error report:
> fs/overlayfs/file.c: In function ‘ovl_file_end_write’:
> fs/overlayfs/file.c:292:51: error: parameter name omitted
>   292 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
>       |                                                   ^~~~~~
> fs/overlayfs/file.c:292:59: error: parameter name omitted
>   292 | static void ovl_file_end_write(struct file *file, loff_t, ssize_t)
>                                                                   ^~~~~~~
>
> Fixes: 291f180e5929 ("fs: pass offset and result to backing_file end_write() callback")
> Signed-off-by: Zheng Zucheng <zhengzucheng@huawei.com>

Thanks for the patch.   The fix is already folded into the original
patch in fuse.git/for-next.

Miklos