[v2] Add ethernet dts schema for qcs615/qcs8300

[PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300

Posted by Yijie Yang 1 month, 1 week ago

Document the ethernet and SerDes compatible for qcs8300. This platform
shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
it.
Document the ethernet compatible for qcs615. This platform shares the
same EMAC as sm8150, so the compatible fallback to it.
Document the compatible for revision 2 of the qcs8300-ride board.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
This patch series depends on below patch series:
https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/

Changes in v2:
- Adjust the position of the EMAC compatible fallback for qcs8300 in the YAML file according to the order. 
- Link to v1: https://lore.kernel.org/r/20241010-schema-v1-0-98b2d0a2f7a2@quicinc.com

---
Yijie Yang (3):
      dt-bindings: net: qcom,ethqos: add description for qcs615
      dt-bindings: phy: describe the Qualcomm SGMII PHY
      dt-bindings: net: qcom,ethqos: add description for qcs8300

 .../devicetree/bindings/net/qcom,ethqos.yaml          | 19 ++++++++++++++-----
 .../bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml    |  7 ++++++-
 2 files changed, 20 insertions(+), 6 deletions(-)
---
base-commit: 40e0c9d414f57d450e3ad03c12765e797fc3fede
change-id: 20241010-schema-50b0b777c28b

Best regards,
-- 
Yijie Yang <quic_yijiyang@quicinc.com>

Re: [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300

Posted by Krzysztof Kozlowski 4 weeks, 1 day ago

On 17/10/2024 11:52, Yijie Yang wrote:
> Document the ethernet and SerDes compatible for qcs8300. This platform
> shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
> it.
> Document the ethernet compatible for qcs615. This platform shares the
> same EMAC as sm8150, so the compatible fallback to it.
> Document the compatible for revision 2 of the qcs8300-ride board.
> 
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
> This patch series depends on below patch series:
> https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/

So it cannot be merged...

Instead please decouple your works. I don't get why do you claim there
is dependency in the first place, but anyway. Fix up your patchsets to
fix that (if there is something to fix).

Best regards,
Krzysztof

Re: [PATCH v2 0/3] Add ethernet dts schema for qcs615/qcs8300

Posted by Yijie Yang 4 weeks ago


On 2024-10-28 19:04, Krzysztof Kozlowski wrote:
> On 17/10/2024 11:52, Yijie Yang wrote:
>> Document the ethernet and SerDes compatible for qcs8300. This platform
>> shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
>> it.
>> Document the ethernet compatible for qcs615. This platform shares the
>> same EMAC as sm8150, so the compatible fallback to it.
>> Document the compatible for revision 2 of the qcs8300-ride board.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>> This patch series depends on below patch series:
>> https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
>> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/
> 
> So it cannot be merged...
> 
> Instead please decouple your works. I don't get why do you claim there
> is dependency in the first place, but anyway. Fix up your patchsets to
> fix that (if there is something to fix).
> 

Actually, the dependency is unnecessary here. I will remove it together 
with the merged patch in the upcoming version.

> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Yijie