As the variables {pos, tmp, block, first_block} are all initialized
prior to their use, remove the unnecessary NULL pointer initializations.

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
Changes in v2:

 - Update the commit message to add the left out variable names {block, first_block}
   that this patch also fixes.

 arch/x86/kernel/cpu/mce/amd.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
index 4dae9841ee38..aecea842dac2 100644
--- a/arch/x86/kernel/cpu/mce/amd.c
+++ b/arch/x86/kernel/cpu/mce/amd.c
@@ -917,8 +917,8 @@ static void log_and_reset_block(struct threshold_block *block)
  */
 static void amd_threshold_interrupt(void)
 {
-	struct threshold_block *first_block = NULL, *block = NULL, *tmp = NULL;
 	struct threshold_bank **bp = this_cpu_read(threshold_banks);
+	struct threshold_block *first_block, *block, *tmp;
 	unsigned int bank, cpu = smp_processor_id();
 
 	/*
@@ -1197,8 +1197,7 @@ static int allocate_threshold_blocks(unsigned int cpu, struct threshold_bank *tb
 static int __threshold_add_blocks(struct threshold_bank *b)
 {
 	struct list_head *head = &b->blocks->miscj;
-	struct threshold_block *pos = NULL;
-	struct threshold_block *tmp = NULL;
+	struct threshold_block *pos, *tmp;
 	int err = 0;
 
 	err = kobject_add(&b->blocks->kobj, b->kobj, b->blocks->kobj.name);
@@ -1308,8 +1307,7 @@ static void deallocate_threshold_blocks(struct threshold_bank *bank)
 
 static void __threshold_remove_blocks(struct threshold_bank *b)
 {
-	struct threshold_block *pos = NULL;
-	struct threshold_block *tmp = NULL;
+	struct threshold_block *pos, *tmp;
 
 	kobject_put(b->kobj);
 
-- 
2.17.1

On 10/16/2024 5:30 AM, Qiuxu Zhuo wrote:
> As the variables {pos, tmp, block, first_block} are all initialized

This level of detail is generally not needed in the commit message. I
would rather just skip the {} brackets altogether.



> prior to their use, remove the unnecessary NULL pointer initializations.
> 
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> ---

> From: Mehta, Sohil <sohil.mehta@intel.com>
> [...]
> Subject: Re: [PATCH v2 09/10] x86/mce/amd: Remove unnecessary NULL
> pointer initializations
> 
> On 10/16/2024 5:30 AM, Qiuxu Zhuo wrote:
> > As the variables {pos, tmp, block, first_block} are all initialized
> 
> This level of detail is generally not needed in the commit message. I would
> rather just skip the {} brackets altogether.

OK. I'll take your suggestion into account in the next version.

-Qiuxu