bcachefs: Correct the description of the '--bucket=size' options

[PATCH] bcachefs: Correct the description of the '--bucket=size' options

Posted by Youling Tang 1 year, 3 months ago

From: Youling Tang <tangyouling@kylinos.cn>

Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
 fs/bcachefs/opts.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/opts.h b/fs/bcachefs/opts.h
index cb2e244a2429..92eae5636f2b 100644
--- a/fs/bcachefs/opts.h
+++ b/fs/bcachefs/opts.h
@@ -487,7 +487,7 @@ enum fsck_err_opts {
 	  OPT_DEVICE,							\
 	  OPT_UINT(0, S64_MAX),						\
 	  BCH2_NO_SB_OPT,		0,				\
-	  "size",	"Size of filesystem on device")			\
+	  "size",	"Specifies the bucket size; must be greater than the btree node size")\
 	x(durability,			u8,				\
 	  OPT_DEVICE|OPT_SB_FIELD_ONE_BIAS,				\
 	  OPT_UINT(0, BCH_REPLICAS_MAX),				\
-- 
2.34.1

Re: [PATCH] bcachefs: Correct the description of the '--bucket=size' options

Posted by Youling Tang 1 year, 3 months ago

Hi, Kent

Give you a friendly ping. 🙂

BTW, is the following patch needed?
[1] 
https://lore.kernel.org/linux-bcachefs/20240709011134.79954-1-youling.tang@linux.dev/
[2] 
https://lore.kernel.org/linux-bcachefs/20240924025350.3948674-1-youling.tang@linux.dev/
[3] 
https://lore.kernel.org/linux-bcachefs/20240927084042.1516361-1-youling.tang@linux.dev/
[4] 
https://lore.kernel.org/linux-bcachefs/20241016014911.1555607-1-youling.tang@linux.dev/

Thanks,
Youling.

On 2024/10/16 09:50, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> ---
>   fs/bcachefs/opts.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/opts.h b/fs/bcachefs/opts.h
> index cb2e244a2429..92eae5636f2b 100644
> --- a/fs/bcachefs/opts.h
> +++ b/fs/bcachefs/opts.h
> @@ -487,7 +487,7 @@ enum fsck_err_opts {
>   	  OPT_DEVICE,							\
>   	  OPT_UINT(0, S64_MAX),						\
>   	  BCH2_NO_SB_OPT,		0,				\
> -	  "size",	"Size of filesystem on device")			\
> +	  "size",	"Specifies the bucket size; must be greater than the btree node size")\
>   	x(durability,			u8,				\
>   	  OPT_DEVICE|OPT_SB_FIELD_ONE_BIAS,				\
>   	  OPT_UINT(0, BCH_REPLICAS_MAX),				\

Re: [PATCH] bcachefs: Correct the description of the '--bucket=size' options

Posted by Kent Overstreet 1 year, 3 months ago

On Thu, Oct 31, 2024 at 04:05:44PM +0800, Youling Tang wrote:
> Hi, Kent
> 
> Give you a friendly ping. 🙂
> 
> BTW, is the following patch needed?
> [1] https://lore.kernel.org/linux-bcachefs/20240709011134.79954-1-youling.tang@linux.dev/
> [2] https://lore.kernel.org/linux-bcachefs/20240924025350.3948674-1-youling.tang@linux.dev/
> [3] https://lore.kernel.org/linux-bcachefs/20240927084042.1516361-1-youling.tang@linux.dev/
> [4] https://lore.kernel.org/linux-bcachefs/20241016014911.1555607-1-youling.tang@linux.dev/

Sorry, been behind :)

All those are in my bcachefs-testing branch now