The RTC does not provide a controllable clock signal (it uses a fixed
32768 Hz crystal, the input clock of the SoC). Remove the 'clocks'
property to better describe the device and avoid errors when checking
the dts against the nxp,lpc3220-rtc binding.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
This patch used to belong to a series that converted the affected RTC
into dtschema[1] (effectively moving it to trivial-rtc), and dropped
the signal clock as it uses a fixed 32768 Hz crystal.

The rest of that series was merged, but I did not get any feedback for
this one. I sent a little reminder ~2 months later that might have gone
unnoticed too, and as a few more months passed since then, I opted for a
resend with the single pending patch. It is of course not urgent, but
still relevant.

Link: https://lore.kernel.org/all/20240413-rtc_dtschema-v3-0-eff368bcc471@gmail.com/ [1]
---
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
index 974410918f35..f78d67e672b4 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
@@ -384,7 +384,6 @@ rtc: rtc@40024000 {
 				reg = <0x40024000 0x1000>;
 				interrupt-parent = <&sic1>;
 				interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk LPC32XX_CLK_RTC>;
 			};
 
 			gpio: gpio@40028000 {

---
base-commit: 15e7d45e786a62a211dd0098fee7c57f84f8c681
change-id: 20241016-lpc32xx-drop-rtc-clock-32acf8f25011

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

Hi Javier.

On 10/16/24 20:14, Javier Carrasco wrote:
> The RTC does not provide a controllable clock signal (it uses a fixed
> 32768 Hz crystal, the input clock of the SoC). Remove the 'clocks'
> property to better describe the device and avoid errors when checking
> the dts against the nxp,lpc3220-rtc binding.
> 

This dts change as well as a counterpart documentation change won't be
applied, since it breaks dtb/Linux ABI, unfortunately.

> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> This patch used to belong to a series that converted the affected RTC
> into dtschema[1] (effectively moving it to trivial-rtc), and dropped
> the signal clock as it uses a fixed 32768 Hz crystal.
> 
> The rest of that series was merged, but I did not get any feedback for
> this one. I sent a little reminder ~2 months later that might have gone
> unnoticed too, and as a few more months passed since then, I opted for a
> resend with the single pending patch. It is of course not urgent, but
> still relevant.
> 
> Link: https://lore.kernel.org/all/20240413-rtc_dtschema-v3-0-eff368bcc471@gmail.com/ [1]

-- 
Best wishes,
Vladimir