Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
register offset was incorrectly set to 8 instead of 0. This prevented
proper GPIO configuration for m5441x targets.

Fixes: 83c6bdb827c9 ("m68knommu: Implement gpio support for m54xx.")
Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
---
 arch/m68k/include/asm/mcfgpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/include/asm/mcfgpio.h b/arch/m68k/include/asm/mcfgpio.h
index 019f24439546..9c91ecdafc45 100644
--- a/arch/m68k/include/asm/mcfgpio.h
+++ b/arch/m68k/include/asm/mcfgpio.h
@@ -136,7 +136,7 @@ static inline void gpio_free(unsigned gpio)
  * read-modify-write as well as those controlled by the EPORT and GPIO modules.
  */
 #define MCFGPIO_SCR_START		40
-#elif defined(CONFIGM5441x)
+#elif defined(CONFIG_M5441x)
 /* The m5441x EPORT doesn't have its own GPIO port, uses PORT C */
 #define MCFGPIO_SCR_START		0
 #else

---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241016-fix-m5441x-gpio-e671833569b4

Best regards,
-- 
Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>

Hi Jean-Michel,

Thanks for your patch!

On Wed, Oct 16, 2024 at 8:45 AM Jean-Michel Hautbois
<jeanmichel.hautbois@yoseli.org> wrote:
> Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
> register offset was incorrectly set to 8 instead of 0. This prevented
> proper GPIO configuration for m5441x targets.
>
> Fixes: 83c6bdb827c9 ("m68knommu: Implement gpio support for m54xx.")

The typo was introduced in a different commit, so the correct tag would be
Fixes: bea8bcb12da09bd3 ("m68knommu: Add support for the Coldfire m5441x.")

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Hi Geert,

On 16/10/2024 08:56, Geert Uytterhoeven wrote:
> Hi Jean-Michel,
> 
> Thanks for your patch!
> 
> On Wed, Oct 16, 2024 at 8:45 AM Jean-Michel Hautbois
> <jeanmichel.hautbois@yoseli.org> wrote:
>> Fix a typo in the CONFIG_M5441x preprocessor condition, where the GPIO
>> register offset was incorrectly set to 8 instead of 0. This prevented
>> proper GPIO configuration for m5441x targets.
>>
>> Fixes: 83c6bdb827c9 ("m68knommu: Implement gpio support for m54xx.")
> 
> The typo was introduced in a different commit, so the correct tag would be
> Fixes: bea8bcb12da09bd3 ("m68knommu: Add support for the Coldfire m5441x.")

Oh gosh, sorry ! Do you want a v2 or would you amend it ?

Thanks for your fast review !

JM

> 
>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
>