net: fec: cleanups, update quirk, update IRQ naming

[PATCH net-next 06/13] net: fec: fec_restart(): make use of FEC_ECR_RESET

Posted by Marc Kleine-Budde 1 month, 1 week ago

Replace the magic number "1" by the already existing define
FEC_ECR_RESET.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 2ee7e4765ba3163fb0d158e60b534b171da26c22..d948ed9810027d5fabe521dc3af2cf505dacd13e 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1089,7 +1089,7 @@ fec_restart(struct net_device *ndev)
 	    ((fep->quirks & FEC_QUIRK_NO_HARD_RESET) && fep->link)) {
 		writel(0, fep->hwp + FEC_ECNTRL);
 	} else {
-		writel(1, fep->hwp + FEC_ECNTRL);
+		writel(FEC_ECR_RESET, fep->hwp + FEC_ECNTRL);
 		udelay(10);
 	}
 

-- 
2.45.2

Re: [PATCH net-next 06/13] net: fec: fec_restart(): make use of FEC_ECR_RESET

Posted by Frank Li 1 month, 1 week ago

On Wed, Oct 16, 2024 at 11:51:54PM +0200, Marc Kleine-Budde wrote:
> Replace the magic number "1" by the already existing define
> FEC_ECR_RESET.

nit: wrap at 75 char.
Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 2ee7e4765ba3163fb0d158e60b534b171da26c22..d948ed9810027d5fabe521dc3af2cf505dacd13e 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1089,7 +1089,7 @@ fec_restart(struct net_device *ndev)
>  	    ((fep->quirks & FEC_QUIRK_NO_HARD_RESET) && fep->link)) {
>  		writel(0, fep->hwp + FEC_ECNTRL);
>  	} else {
> -		writel(1, fep->hwp + FEC_ECNTRL);
> +		writel(FEC_ECR_RESET, fep->hwp + FEC_ECNTRL);
>  		udelay(10);
>  	}
>
>
> --
> 2.45.2
>
>

Re: [PATCH net-next 06/13] net: fec: fec_restart(): make use of FEC_ECR_RESET

Posted by Marc Kleine-Budde 1 month, 1 week ago

On 16.10.2024 22:07:04, Frank Li wrote:
> On Wed, Oct 16, 2024 at 11:51:54PM +0200, Marc Kleine-Budde wrote:
> > Replace the magic number "1" by the already existing define
> > FEC_ECR_RESET.
> 
> nit: wrap at 75 char.
> Reviewed-by: Frank Li <Frank.Li@nxp.com>

Fixed,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |