1. Patchew
  2. linux
  3. View series

[PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply

Marek Vasut posted 1 patch 1 month, 1 week ago 
.../boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi  | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
[PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
Posted by Marek Vasut 1 month, 1 week ago 
Add missing panel power-supply property to DT to fix the following warning.
The power supply on this device is very simple chain of regulators from the
main 24V input, describe those.

"
arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required property
"

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 .../boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
index 773fdcfcd0015..d7c2b30aecfd1 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
@@ -143,6 +143,7 @@ led-8 {
 	panel {
 		backlight = <&display_bl>;
 		compatible = "edt,etm0700g0edh6";
+		power-supply = <&reg_panel_3v3>;
 
 		port {
 			lcd_panel_in: endpoint {
@@ -151,6 +152,25 @@ lcd_panel_in: endpoint {
 		};
 	};
 
+	/* Filtered supply voltage */
+	reg_pdk2_24v: regulator-pdk2-24v {
+		compatible = "regulator-fixed";
+		regulator-always-on;
+		regulator-max-microvolt = <24000000>;
+		regulator-min-microvolt = <24000000>;
+		regulator-name = "24V_PDK2";
+	};
+
+	/* 560-200 U1 */
+	reg_panel_3v3: regulator-panel-3v3 {
+		compatible = "regulator-fixed";
+		regulator-always-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-name = "3V3_PANEL";
+		vin-supply = <&reg_pdk2_24v>;
+	};
+
 	sound {
 		audio-codec = <&sgtl5000>;
 		audio-routing =
-- 
2.45.2
Re: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
Posted by Shawn Guo 1 month ago 
On Wed, Oct 16, 2024 at 01:24:51AM +0200, Marek Vasut wrote:
> Add missing panel power-supply property to DT to fix the following warning.
> The power supply on this device is very simple chain of regulators from the
> main 24V input, describe those.
> 
> "
> arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required property
> "
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks!
RE: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Fill in missing panel power-supply
Posted by Christoph Niedermaier 1 month, 1 week ago 
From: Marek Vasut <marex@denx.de>
Sent: Wednesday, October 16, 2024 1:25 AM
> Add missing panel power-supply property to DT to fix the following warning.
> The power supply on this device is very simple chain of regulators from the
> main 24V input, describe those.
> 
> "
> arch/arm/boot/dts/nxp/imx/imx6q-dhcom-pdk2.dtb: panel: 'power-supply' is a required
> property
> "
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  .../boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi  | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> index 773fdcfcd0015..d7c2b30aecfd1 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> @@ -143,6 +143,7 @@ led-8 {
>         panel {
>                 backlight = <&display_bl>;
>                 compatible = "edt,etm0700g0edh6";
> +               power-supply = <&reg_panel_3v3>;
> 
>                 port {
>                         lcd_panel_in: endpoint {
> @@ -151,6 +152,25 @@ lcd_panel_in: endpoint {
>                 };
>         };
> 
> +       /* Filtered supply voltage */
> +       reg_pdk2_24v: regulator-pdk2-24v {
> +               compatible = "regulator-fixed";
> +               regulator-always-on;
> +               regulator-max-microvolt = <24000000>;
> +               regulator-min-microvolt = <24000000>;
> +               regulator-name = "24V_PDK2";
> +       };
> +
> +       /* 560-200 U1 */
> +       reg_panel_3v3: regulator-panel-3v3 {
> +               compatible = "regulator-fixed";
> +               regulator-always-on;
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               regulator-name = "3V3_PANEL";
> +               vin-supply = <&reg_pdk2_24v>;
> +       };
> +
>         sound {
>                 audio-codec = <&sgtl5000>;
>                 audio-routing =

Reviewed-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.