[v7] ibm: emac: more cleanups

[PATCHv7 net-next 0/6] ibm: emac: more cleanups

Posted by Rosen Penev 1 month, 1 week ago

Tested on Cisco MX60W.

v2: fixed build errors. Also added extra commits to clean the driver up
further.
v3: Added tested message. Removed bad alloc_netdev_dummy commit.
v4: removed modules changes from patchset. Added fix for if MAC not
found.
v5: added of_find_matching_node commit.
v6: resend after net-next merge.
v7: removed of_find_matching_node commit. Adjusted mutex_init patch.

Rosen Penev (6):
  net: ibm: emac: use netif_receive_skb_list
  net: ibm: emac: remove custom init/exit functions
  net: ibm: emac: use devm_platform_ioremap_resource
  net: ibm: emac: use platform_get_irq
  net: ibm: emac: use devm for mutex_init
  net: ibm: emac: generate random MAC if not found

 drivers/net/ethernet/ibm/emac/core.c  | 81 ++++++++-------------------
 drivers/net/ethernet/ibm/emac/mal.c   | 10 +---
 drivers/net/ethernet/ibm/emac/mal.h   |  4 --
 drivers/net/ethernet/ibm/emac/rgmii.c | 10 +---
 drivers/net/ethernet/ibm/emac/rgmii.h |  4 --
 drivers/net/ethernet/ibm/emac/tah.c   | 10 +---
 drivers/net/ethernet/ibm/emac/tah.h   |  4 --
 drivers/net/ethernet/ibm/emac/zmii.c  | 10 +---
 drivers/net/ethernet/ibm/emac/zmii.h  |  4 --
 9 files changed, 27 insertions(+), 110 deletions(-)

-- 
2.47.0

Re: [PATCHv7 net-next 0/6] ibm: emac: more cleanups

Posted by Rosen Penev 1 month, 1 week ago

On Tue, Oct 15, 2024 at 1:02 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> Tested on Cisco MX60W.
>
> v2: fixed build errors. Also added extra commits to clean the driver up
> further.
> v3: Added tested message. Removed bad alloc_netdev_dummy commit.
> v4: removed modules changes from patchset. Added fix for if MAC not
> found.
> v5: added of_find_matching_node commit.
> v6: resend after net-next merge.
> v7: removed of_find_matching_node commit. Adjusted mutex_init patch.
>
> Rosen Penev (6):
>   net: ibm: emac: use netif_receive_skb_list
>   net: ibm: emac: remove custom init/exit functions
>   net: ibm: emac: use devm_platform_ioremap_resource
>   net: ibm: emac: use platform_get_irq
>   net: ibm: emac: use devm for mutex_init
>   net: ibm: emac: generate random MAC if not found
why is this set to changes requested?
>
>  drivers/net/ethernet/ibm/emac/core.c  | 81 ++++++++-------------------
>  drivers/net/ethernet/ibm/emac/mal.c   | 10 +---
>  drivers/net/ethernet/ibm/emac/mal.h   |  4 --
>  drivers/net/ethernet/ibm/emac/rgmii.c | 10 +---
>  drivers/net/ethernet/ibm/emac/rgmii.h |  4 --
>  drivers/net/ethernet/ibm/emac/tah.c   | 10 +---
>  drivers/net/ethernet/ibm/emac/tah.h   |  4 --
>  drivers/net/ethernet/ibm/emac/zmii.c  | 10 +---
>  drivers/net/ethernet/ibm/emac/zmii.h  |  4 --
>  9 files changed, 27 insertions(+), 110 deletions(-)
>
> --
> 2.47.0
>

Re: [PATCHv7 net-next 0/6] ibm: emac: more cleanups

Posted by Simon Horman 1 month, 1 week ago

On Wed, Oct 16, 2024 at 11:28:49AM -0700, Rosen Penev wrote:
> On Tue, Oct 15, 2024 at 1:02 PM Rosen Penev <rosenp@gmail.com> wrote:
> >
> > Tested on Cisco MX60W.
> >
> > v2: fixed build errors. Also added extra commits to clean the driver up
> > further.
> > v3: Added tested message. Removed bad alloc_netdev_dummy commit.
> > v4: removed modules changes from patchset. Added fix for if MAC not
> > found.
> > v5: added of_find_matching_node commit.
> > v6: resend after net-next merge.
> > v7: removed of_find_matching_node commit. Adjusted mutex_init patch.
> >
> > Rosen Penev (6):
> >   net: ibm: emac: use netif_receive_skb_list
> >   net: ibm: emac: remove custom init/exit functions
> >   net: ibm: emac: use devm_platform_ioremap_resource
> >   net: ibm: emac: use platform_get_irq
> >   net: ibm: emac: use devm for mutex_init
> >   net: ibm: emac: generate random MAC if not found
> why is this set to changes requested?

That isn't clear to me either.
Let's try this:

pw-bot: under-review