[PATCH] rtc: add prefix modalias for rtc modules

huanglei814 posted 1 patch 1 month, 1 week ago
drivers/rtc/rtc-ds1302.c | 1 +
drivers/rtc/rtc-ds1307.c | 1 +
drivers/rtc/rtc-ds1343.c | 1 +
drivers/rtc/rtc-ds1347.c | 1 +
drivers/rtc/rtc-ds1374.c | 1 +
drivers/rtc/rtc-ds1672.c | 1 +
6 files changed, 6 insertions(+)
[PATCH] rtc: add prefix modalias for rtc modules
Posted by huanglei814 1 month, 1 week ago
From: huanglei <huanglei@kylinos.cn>

When these rtc drivers is built as a module, To wire it up to udev,
and let the module be loaded automatically, we need to export these
alias from the modules.

Signed-off-by: huanglei <huanglei@kylinos.cn>
---
 drivers/rtc/rtc-ds1302.c | 1 +
 drivers/rtc/rtc-ds1307.c | 1 +
 drivers/rtc/rtc-ds1343.c | 1 +
 drivers/rtc/rtc-ds1347.c | 1 +
 drivers/rtc/rtc-ds1374.c | 1 +
 drivers/rtc/rtc-ds1672.c | 1 +
 6 files changed, 6 insertions(+)

diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c
index ecc7d0307932..cc82f8e6326b 100644
--- a/drivers/rtc/rtc-ds1302.c
+++ b/drivers/rtc/rtc-ds1302.c
@@ -211,3 +211,4 @@ module_spi_driver(ds1302_driver);
 MODULE_DESCRIPTION("Dallas DS1302 RTC driver");
 MODULE_AUTHOR("Paul Mundt, David McCullough");
 MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("spi:rtc-ds1302");
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 872e0b679be4..c402ab5cf383 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -2024,3 +2024,4 @@ module_i2c_driver(ds1307_driver);
 
 MODULE_DESCRIPTION("RTC driver for DS1307 and similar chips");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("i2c:rtc-ds1307");
diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c
index ed5a6ba89a3e..e9183f745922 100644
--- a/drivers/rtc/rtc-ds1343.c
+++ b/drivers/rtc/rtc-ds1343.c
@@ -481,3 +481,4 @@ MODULE_DESCRIPTION("DS1343 RTC SPI Driver");
 MODULE_AUTHOR("Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>,"
 		"Ankur Srivastava <sankurece@gmail.com>");
 MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("spi:ds1343");
diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
index a40c1a52df65..babdd35cd82d 100644
--- a/drivers/rtc/rtc-ds1347.c
+++ b/drivers/rtc/rtc-ds1347.c
@@ -181,3 +181,4 @@ module_spi_driver(ds1347_driver);
 MODULE_DESCRIPTION("DS1347 SPI RTC DRIVER");
 MODULE_AUTHOR("Raghavendra C Ganiga <ravi23ganiga@gmail.com>");
 MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("spi:ds1347");
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index c2359eb86bc9..3d61ab23c41c 100644
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -582,3 +582,4 @@ module_i2c_driver(ds1374_driver);
 MODULE_AUTHOR("Scott Wood <scottwood@freescale.com>");
 MODULE_DESCRIPTION("Maxim/Dallas DS1374 RTC Driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("i2c:rtc-ds1374");
diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c
index 6e5314215d00..a2240cd92774 100644
--- a/drivers/rtc/rtc-ds1672.c
+++ b/drivers/rtc/rtc-ds1672.c
@@ -158,3 +158,4 @@ module_i2c_driver(ds1672_driver);
 MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
 MODULE_DESCRIPTION("Dallas/Maxim DS1672 timekeeper driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("i2c:rtc-ds1672");
-- 
2.17.1
Re: [PATCH] rtc: add prefix modalias for rtc modules
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 15/10/2024 04:43, huanglei814 wrote:
> From: huanglei <huanglei@kylinos.cn>
> 
> When these rtc drivers is built as a module, To wire it up to udev,
> and let the module be loaded automatically, we need to export these
> alias from the modules.
> 
> Signed-off-by: huanglei <huanglei@kylinos.cn>
> ---
>  drivers/rtc/rtc-ds1302.c | 1 +
>  drivers/rtc/rtc-ds1307.c | 1 +
>  drivers/rtc/rtc-ds1343.c | 1 +
>  drivers/rtc/rtc-ds1347.c | 1 +
>  drivers/rtc/rtc-ds1374.c | 1 +
>  drivers/rtc/rtc-ds1672.c | 1 +
>  6 files changed, 6 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c
> index ecc7d0307932..cc82f8e6326b 100644
> --- a/drivers/rtc/rtc-ds1302.c
> +++ b/drivers/rtc/rtc-ds1302.c
> @@ -211,3 +211,4 @@ module_spi_driver(ds1302_driver);
>  MODULE_DESCRIPTION("Dallas DS1302 RTC driver");
>  MODULE_AUTHOR("Paul Mundt, David McCullough");
>  MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("spi:rtc-ds1302");

NAK. That's neither correct, nor necessary. Driver has proper tables and
is loaded automatically in correct setup. I assume your setup is just
incorrect, but without description tricky to say how.

Best regards,
Krzysztof