[v1] ad7380: add adaq4370-4 and adaq4380-4 support

[PATCH RFC 0/4] ad7380: add adaq4370-4 and adaq4380-4 support

Posted by Julien Stephan 1 month, 1 week ago

Hello,

This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
which are quad-channel precision data acquisition signal chain μModule
solutions compatible with the ad738x family, with the following differences:

- configurable gain in front of each 4 adc
- internal reference is 3V derived from refin-supply (5V)
- additional supplies

This series depends on [1] which fix several supplies issues

[1]: https://lore.kernel.org/all/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com/

Signed-off-by: Julien Stephan <jstephan@baylibre.com>
---
Julien Stephan (4):
      dt-bindings: iio: adc: ad7380: add adaq4370-4 and adaq4380-4 compatible parts
      iio: adc: ad7380: fix oversampling formula
      iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4
      docs: iio: ad7380: add adaq4370-4 and adaq4380-4

 .../devicetree/bindings/iio/adc/adi,ad7380.yaml    | 117 ++++++++++++++++++
 Documentation/iio/ad7380.rst                       |  15 +++
 drivers/iio/adc/ad7380.c                           | 135 +++++++++++++++++++--
 3 files changed, 258 insertions(+), 9 deletions(-)
---
base-commit: 8bea3878a1511bceadc2fbf284b00bcc5a2ef28d
change-id: 20241015-ad7380-add-adaq4380-4-support-14dc17ec0029
prerequisite-change-id: 20241004-ad7380-fix-supplies-3677365cf8aa:v1
prerequisite-patch-id: 6d87f69eed38931663a1fe4035d92bdddcc06da2
prerequisite-patch-id: 337292de00e31ecc2f71eac207542f236d8c0ff4
prerequisite-patch-id: 7dee57142d0d12682b0be3b62f1c16851aeac069
prerequisite-patch-id: 4ca1d234fa53f27d4e73150df5b00e245a142f67
prerequisite-patch-id: d42f3c478b92a6f97194853fac271add226803cf
prerequisite-patch-id: 972bdbf06bafa7c56f604dbe8eb7d236aadaad99

Best regards,
-- 
Julien Stephan <jstephan@baylibre.com>

Re: [PATCH RFC 0/4] ad7380: add adaq4370-4 and adaq4380-4 support

Posted by Conor Dooley 1 month, 1 week ago

On Tue, Oct 15, 2024 at 11:09:05AM +0200, Julien Stephan wrote:
> Hello,
> 
> This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> which are quad-channel precision data acquisition signal chain μModule
> solutions compatible with the ad738x family, with the following differences:
> 
> - configurable gain in front of each 4 adc
> - internal reference is 3V derived from refin-supply (5V)
> - additional supplies
> 
> This series depends on [1] which fix several supplies issues
> 
> [1]: https://lore.kernel.org/all/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com/

What exactly makes this series RFC rather than v1?

Re: [PATCH RFC 0/4] ad7380: add adaq4370-4 and adaq4380-4 support

Posted by Julien Stephan 1 month, 1 week ago

Le mar. 15 oct. 2024 à 18:43, Conor Dooley <conor@kernel.org> a écrit :
>
> On Tue, Oct 15, 2024 at 11:09:05AM +0200, Julien Stephan wrote:
> > Hello,
> >
> > This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> > which are quad-channel precision data acquisition signal chain μModule
> > solutions compatible with the ad738x family, with the following differences:
> >
> > - configurable gain in front of each 4 adc
> > - internal reference is 3V derived from refin-supply (5V)
> > - additional supplies
> >
> > This series depends on [1] which fix several supplies issues
> >
> > [1]: https://lore.kernel.org/all/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com/
>
> What exactly makes this series RFC rather than v1?

Hi Conor,
I am sorry I forgot to add some context here... There is an ongoing
discussion on the dependent series about power supplies and Jonathan
asked me to send this series to see how to properly handle the supply
fix...
See  https://lore.kernel.org/all/20241014193701.40e3785a@jic23-huawei/

Cheers,
Julien

Re: [PATCH RFC 0/4] ad7380: add adaq4370-4 and adaq4380-4 support

Posted by Jonathan Cameron 1 month, 1 week ago

On Wed, 16 Oct 2024 09:25:53 +0200
Julien Stephan <jstephan@baylibre.com> wrote:

> Le mar. 15 oct. 2024 à 18:43, Conor Dooley <conor@kernel.org> a écrit :
> >
> > On Tue, Oct 15, 2024 at 11:09:05AM +0200, Julien Stephan wrote:  
> > > Hello,
> > >
> > > This series add support for adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS)
> > > which are quad-channel precision data acquisition signal chain μModule
> > > solutions compatible with the ad738x family, with the following differences:
> > >
> > > - configurable gain in front of each 4 adc
> > > - internal reference is 3V derived from refin-supply (5V)
> > > - additional supplies
> > >
> > > This series depends on [1] which fix several supplies issues
> > >
> > > [1]: https://lore.kernel.org/all/20241007-ad7380-fix-supplies-v1-0-badcf813c9b9@baylibre.com/  
> >
> > What exactly makes this series RFC rather than v1?  
> 
> Hi Conor,
> I am sorry I forgot to add some context here... There is an ongoing
> discussion on the dependent series about power supplies and Jonathan
> asked me to send this series to see how to properly handle the supply
> fix...
> See  https://lore.kernel.org/all/20241014193701.40e3785a@jic23-huawei/

Thanks,

It did the job for that.  Given it's on list, do you want a review
of the rest of the patch set, or is it still enough of a work in progress
that we should hold off?

Thanks,

Jonathan

> 
> Cheers,
> Julien
>