platform/x86: dell-wmi: Ignore suspend notifications

[PATCH] platform/x86: dell-wmi: Ignore suspend notifications

Posted by Armin Wolf 1 month, 1 week ago

Some machines like the Dell G15 5155 emit WMI events when
suspending/resuming. Ignore those WMI events.

Tested-by: siddharth.manthan@gmail.com
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
For some reason mjg59@srcf.ucam.org causes a local error in processing.
---
 drivers/platform/x86/dell/dell-wmi-base.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
index 502783a7adb1..24fd7ffadda9 100644
--- a/drivers/platform/x86/dell/dell-wmi-base.c
+++ b/drivers/platform/x86/dell/dell-wmi-base.c
@@ -264,6 +264,15 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
 	/*Speaker Mute*/
 	{ KE_KEY, 0x109, { KEY_MUTE} },

+	/* S2Idle screen off */
+	{ KE_IGNORE, 0x120, { KEY_RESERVED }},
+
+	/* Leaving S4 or S2Idle suspend */
+	{ KE_IGNORE, 0x130, { KEY_RESERVED }},
+
+	/* Entering S2Idle suspend */
+	{ KE_IGNORE, 0x140, { KEY_RESERVED }},
+
 	/* Mic mute */
 	{ KE_KEY, 0x150, { KEY_MICMUTE } },

--
2.39.5

Re: [PATCH] platform/x86: dell-wmi: Ignore suspend notifications

Posted by Hans de Goede 1 month ago

Hi,

On 15-Oct-24 12:05 AM, Armin Wolf wrote:
> Some machines like the Dell G15 5155 emit WMI events when
> suspending/resuming. Ignore those WMI events.
> 
> Tested-by: siddharth.manthan@gmail.com
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans




> ---
> For some reason mjg59@srcf.ucam.org causes a local error in processing.
> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 502783a7adb1..24fd7ffadda9 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -264,6 +264,15 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	/*Speaker Mute*/
>  	{ KE_KEY, 0x109, { KEY_MUTE} },
> 
> +	/* S2Idle screen off */
> +	{ KE_IGNORE, 0x120, { KEY_RESERVED }},
> +
> +	/* Leaving S4 or S2Idle suspend */
> +	{ KE_IGNORE, 0x130, { KEY_RESERVED }},
> +
> +	/* Entering S2Idle suspend */
> +	{ KE_IGNORE, 0x140, { KEY_RESERVED }},
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
> 
> --
> 2.39.5
>

Re: [PATCH] platform/x86: dell-wmi: Ignore suspend notifications

Posted by Armin Wolf 1 month ago

Am 21.10.24 um 16:23 schrieb Hans de Goede:

> Hi,
>
> On 15-Oct-24 12:05 AM, Armin Wolf wrote:
>> Some machines like the Dell G15 5155 emit WMI events when
>> suspending/resuming. Ignore those WMI events.
>>
>> Tested-by: siddharth.manthan@gmail.com
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
>
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.
>
> Regards,
>
> Hans

Thanks :)

>> ---
>> For some reason mjg59@srcf.ucam.org causes a local error in processing.
>> ---
>>   drivers/platform/x86/dell/dell-wmi-base.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> index 502783a7adb1..24fd7ffadda9 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> @@ -264,6 +264,15 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>>   	/*Speaker Mute*/
>>   	{ KE_KEY, 0x109, { KEY_MUTE} },
>>
>> +	/* S2Idle screen off */
>> +	{ KE_IGNORE, 0x120, { KEY_RESERVED }},
>> +
>> +	/* Leaving S4 or S2Idle suspend */
>> +	{ KE_IGNORE, 0x130, { KEY_RESERVED }},
>> +
>> +	/* Entering S2Idle suspend */
>> +	{ KE_IGNORE, 0x140, { KEY_RESERVED }},
>> +
>>   	/* Mic mute */
>>   	{ KE_KEY, 0x150, { KEY_MICMUTE } },
>>
>> --
>> 2.39.5
>>
>

Re: [PATCH] platform/x86: dell-wmi: Ignore suspend notifications

Posted by Pali Rohár 1 month, 1 week ago

On Tuesday 15 October 2024 00:05:29 Armin Wolf wrote:
> Some machines like the Dell G15 5155 emit WMI events when
> suspending/resuming. Ignore those WMI events.
> 
> Tested-by: siddharth.manthan@gmail.com
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Looks good,

Acked-by: Pali Rohár <pali@kernel.org>

> ---
> For some reason mjg59@srcf.ucam.org causes a local error in processing.
> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 502783a7adb1..24fd7ffadda9 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -264,6 +264,15 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	/*Speaker Mute*/
>  	{ KE_KEY, 0x109, { KEY_MUTE} },
> 
> +	/* S2Idle screen off */
> +	{ KE_IGNORE, 0x120, { KEY_RESERVED }},
> +
> +	/* Leaving S4 or S2Idle suspend */
> +	{ KE_IGNORE, 0x130, { KEY_RESERVED }},
> +
> +	/* Entering S2Idle suspend */
> +	{ KE_IGNORE, 0x140, { KEY_RESERVED }},
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
> 
> --
> 2.39.5
>