[PATCH 1/2] mailbox: ti-msgmgr: Remove use of of_match_ptr() helper

Andrew Davis posted 2 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 1/2] mailbox: ti-msgmgr: Remove use of of_match_ptr() helper
Posted by Andrew Davis 1 month, 1 week ago
When OF support is disabled the of_device_id struct match table can be
conditionally compiled out, this helper allows the assignment to also be
turned into a NULL conditionally. When the of_device_id struct is not
conditionally defined based on OF then the table will be unused causing a
warning. The two options are to either set the table as _maybe_unused, or
to just remove this helper since the table will always be defined.
Do the latter here.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/mailbox/ti-msgmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index 9d2d4ff6cda40..8eb8df8d95a4c 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -920,7 +920,7 @@ static struct platform_driver ti_msgmgr_driver = {
 	.probe = ti_msgmgr_probe,
 	.driver = {
 		   .name = "ti-msgmgr",
-		   .of_match_table = of_match_ptr(ti_msgmgr_of_match),
+		   .of_match_table = ti_msgmgr_of_match,
 		   .pm = &ti_msgmgr_pm_ops,
 	},
 };
-- 
2.39.2
Re: [PATCH 1/2] mailbox: ti-msgmgr: Remove use of of_match_ptr() helper
Posted by Arnd Bergmann 1 month, 1 week ago
On Mon, Oct 14, 2024, at 14:48, Andrew Davis wrote:
> When OF support is disabled the of_device_id struct match table can be
> conditionally compiled out, this helper allows the assignment to also be
> turned into a NULL conditionally. When the of_device_id struct is not
> conditionally defined based on OF then the table will be unused causing a
> warning. The two options are to either set the table as _maybe_unused, or
> to just remove this helper since the table will always be defined.
> Do the latter here.
>
> Signed-off-by: Andrew Davis <afd@ti.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>