Select configs that do not have a prompt. Config options can be bool or
tristate. Ensure that bool options are also selected.

Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
V1 https://lore.kernel.org/all/20240913171205.22126-2-david.hunter.linux@gmail.com/

V2
	- changed patch subject
	- changed the order of this patch in the series patch
---
 scripts/kconfig/streamline_config.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 4038afed2926..8c75ab888f87 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -273,7 +273,7 @@ sub read_kconfig {
 	    }
 
 	# configs without prompts must be selected
-	} elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) {
+	} elsif ($state ne "NONE" && /^\s*((bool|tristate)\s+\S|prompt\b)/) {
 	    # note if the config has a prompt
 	    $prompts{$config} = 1;
 
-- 
2.43.0

On Mon, Oct 14, 2024 at 11:14 PM David Hunter
<david.hunter.linux@gmail.com> wrote:
>
> Select configs that do not have a prompt. Config options can be bool or
> tristate. Ensure that bool options are also selected.
>
> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
> ---
> V1 https://lore.kernel.org/all/20240913171205.22126-2-david.hunter.linux@gmail.com/
>
> V2
>         - changed patch subject
>         - changed the order of this patch in the series patch
> ---

As I reviewed in v1, this patch depends on 6/7.




-- 
Best Regards
Masahiro Yamada

> As I reviewed in v1, this patch depends on 6/7.

Hello,

I am a little confused by this part. I originally understood this to say 
that I should put it after the 6/7 patch because it depends on it. 
Should I have combined the two patches into one?

Sorry for not understanding.

On Wed, Nov 27, 2024 at 10:27 PM David Hunter
<david.hunter.linux@gmail.com> wrote:
>
>
> > As I reviewed in v1, this patch depends on 6/7.
>
> Hello,
>
> I am a little confused by this part. I originally understood this to say
> that I should put it after the 6/7 patch because it depends on it.
> Should I have combined the two patches into one?
>
> Sorry for not understanding.

No. What I understood from Steven's feedback is,
6/7 is skeptical.

6/7 enables many unnecessary modules because of them depending on 'y',
but most of the cases, the 'y' value is module-internal switch.

While 6/7 may save some false-negatives,
it introduces many false-positives.
So, I do not know whether it should get in or not.

If we do not apply 6/7, there is not reason to apply 7/7 either.



--
Best Regards
Masahiro Yamada

Understood.