[v1] dma/dw-edma: chip regs base should add the offset

[PATCH] dma/dw-edma: chip regs base should add the offset

Posted by ChunyouTang 1 month, 1 week ago

From: tangchunyou <tangchunyou@163.com>

fix the regs base with offset.

Signed-off-by: tangchunyou <tangchunyou@163.com>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index 1c6043751dc9..2918b64708f9 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
 	if (!chip->reg_base)
 		return -ENOMEM;
 
+	chip->reg_base += vsec_data.rg.off;
+
 	for (i = 0; i < chip->ll_wr_cnt; i++) {
 		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
 		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
-- 
2.25.1

Re: [PATCH] dma/dw-edma: chip regs base should add the offset

Posted by Manivannan Sadhasivam 1 month, 1 week ago

On Mon, Oct 14, 2024 at 09:48:32PM +0800, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@163.com>
> 
> fix the regs base with offset.
> 

Initially I thought that this patch is a spam, but it is not. It is indeed
fixing a real bug in the driver. But the subject and description made it look
like a spam. Please follow the process defined in:
Documentation/process/5.Posting.rst to send the patches.

Essentially you need to properly describe what the patch does and how it impacts
the driver etc... Then there needs to be a valid 'Fixes' tag and stable list
should be CCed to backport to stable kernels.

- Mani

> Signed-off-by: tangchunyou <tangchunyou@163.com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index 1c6043751dc9..2918b64708f9 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	if (!chip->reg_base)
>  		return -ENOMEM;
>  
> +	chip->reg_base += vsec_data.rg.off;
> +
>  	for (i = 0; i < chip->ll_wr_cnt; i++) {
>  		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
>  		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
> -- 
> 2.25.1
> 

-- 
மணிவண்ணன் சதாசிவம்

Re:Re: [PATCH] dma/dw-edma: chip regs base should add the offset

Posted by 唐春有 1 month, 1 week ago

hi Mani:

sorry, I am a novice in submitting patches. Do you think my modifications meet the requirements? If not, please help point out the problem, preferably with an example. Thank you!

I had modify it in the attachment.




chunyou














At 2024-10-15 13:36:08, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org> wrote:
>On Mon, Oct 14, 2024 at 09:48:32PM +0800, ChunyouTang wrote:
>> From: tangchunyou <tangchunyou@163.com>
>> 
>> fix the regs base with offset.
>> 
>
>Initially I thought that this patch is a spam, but it is not. It is indeed
>fixing a real bug in the driver. But the subject and description made it look
>like a spam. Please follow the process defined in:
>Documentation/process/5.Posting.rst to send the patches.
>
>Essentially you need to properly describe what the patch does and how it impacts
>the driver etc... Then there needs to be a valid 'Fixes' tag and stable list
>should be CCed to backport to stable kernels.
>
>- Mani
>
>> Signed-off-by: tangchunyou <tangchunyou@163.com>
>> ---
>>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
>> index 1c6043751dc9..2918b64708f9 100644
>> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
>> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
>> @@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>>  	if (!chip->reg_base)
>>  		return -ENOMEM;
>>  
>> +	chip->reg_base += vsec_data.rg.off;
>> +
>>  	for (i = 0; i < chip->ll_wr_cnt; i++) {
>>  		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
>>  		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
>> -- 
>> 2.25.1
>> 
>
>-- 
>மணிவண்ணன் சதாசிவம்
From 8a18b2b05a6b0c9182288f5549f564b61bb2e1e3 Mon Sep 17 00:00:00 2001
From: tangchunyou <tangchunyou@163.com>
Date: Mon, 14 Oct 2024 19:15:09 +0800
Subject: [PATCH] dma/dw-edma: chip regs base should add the offset

1. the regs base in the bar have an offset rg.off
2. add the offset to obtain the real reg_base

Signed-off-by: tangchunyou <tangchunyou@163.com>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index 1c6043751dc9..2918b64708f9 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
 	if (!chip->reg_base)
 		return -ENOMEM;
 
+	chip->reg_base += vsec_data.rg.off;
+
 	for (i = 0; i < chip->ll_wr_cnt; i++) {
 		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
 		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
-- 
2.25.1

Re: Re: [PATCH] dma/dw-edma: chip regs base should add the offset

Posted by Vinod Koul 1 month, 1 week ago

On 15-10-24, 18:45, 唐春有 wrote:
> hi Mani:
> 
> sorry, I am a novice in submitting patches. Do you think my modifications meet the requirements? If not, please help point out the problem, preferably with an example. Thank you!

Please do NOT top post
> 
> I had modify it in the attachment.

Please read again the Documentation/process/development-process.rst on
how to follow up on comments and post an update and how to describe your
changes

> 
> 
> 
> 
> chunyou
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> At 2024-10-15 13:36:08, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org> wrote:
> >On Mon, Oct 14, 2024 at 09:48:32PM +0800, ChunyouTang wrote:
> >> From: tangchunyou <tangchunyou@163.com>
> >> 
> >> fix the regs base with offset.
> >> 
> >
> >Initially I thought that this patch is a spam, but it is not. It is indeed
> >fixing a real bug in the driver. But the subject and description made it look
> >like a spam. Please follow the process defined in:
> >Documentation/process/5.Posting.rst to send the patches.
> >
> >Essentially you need to properly describe what the patch does and how it impacts
> >the driver etc... Then there needs to be a valid 'Fixes' tag and stable list
> >should be CCed to backport to stable kernels.
> >
> >- Mani
> >
> >> Signed-off-by: tangchunyou <tangchunyou@163.com>
> >> ---
> >>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> >> index 1c6043751dc9..2918b64708f9 100644
> >> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> >> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> >> @@ -234,6 +234,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
> >>  	if (!chip->reg_base)
> >>  		return -ENOMEM;
> >>  
> >> +	chip->reg_base += vsec_data.rg.off;
> >> +
> >>  	for (i = 0; i < chip->ll_wr_cnt; i++) {
> >>  		struct dw_edma_region *ll_region = &chip->ll_region_wr[i];
> >>  		struct dw_edma_region *dt_region = &chip->dt_region_wr[i];
> >> -- 
> >> 2.25.1
> >> 
> >
> >-- 
> >மணிவண்ணன் சதாசிவம்



-- 
~Vinod