gpio: fold the Kconfig prompt into the option type for GPIO CDEV

[PATCH] gpio: fold the Kconfig prompt into the option type for GPIO CDEV

Posted by Bartosz Golaszewski 1 month, 1 week ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The 'if !EXPERT' bit will work fine if it follows the 'bool "foobar"'
declaration. No need to have separate entries for it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bfa6b5a2c537..7f59e861de5b 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -70,8 +70,7 @@ config GPIO_SYSFS
 	  ioctl() operations instead.
 
 config GPIO_CDEV
-	bool
-	prompt "Character device (/dev/gpiochipN) support" if EXPERT
+	bool "Character device (/dev/gpiochipN) support" if EXPERT
 	default y
 	help
 	  Say Y here to add the character device /dev/gpiochipN interface
-- 
2.43.0

Re: [PATCH] gpio: fold the Kconfig prompt into the option type for GPIO CDEV

Posted by Bartosz Golaszewski 1 month, 1 week ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 14 Oct 2024 13:07:07 +0200, Bartosz Golaszewski wrote:
> The 'if !EXPERT' bit will work fine if it follows the 'bool "foobar"'
> declaration. No need to have separate entries for it.
> 
> 

Applied, thanks!

[1/1] gpio: fold the Kconfig prompt into the option type for GPIO CDEV
      commit: 3dcf0643fa5cd65e667057cfa11d6e54ac36f2ff

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH] gpio: fold the Kconfig prompt into the option type for GPIO CDEV

Posted by Linus Walleij 1 month, 1 week ago

On Mon, Oct 14, 2024 at 1:07 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The 'if !EXPERT' bit will work fine if it follows the 'bool "foobar"'

Nit: if EXPERT

No negation.

> declaration. No need to have separate entries for it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij