[v2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

[PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

Posted by Javier Carrasco 1 month, 1 week ago

This series refactors some useless goto instructions as a preparation
for the fix of a missing of_node_put() by means of the cleanup
attribute.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Changes in v2:
- Refactor vchiq_probe() to remove goto instructions.
- Declare and initialize the node right before its first usage.
- Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com

---
Javier Carrasco (2):
      staging: vchiq_arm: refactor goto instructions in vchiq_probe()
      staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

 .../vc04_services/interface/vchiq_arm/vchiq_arm.c     | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)
---
base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
change-id: 20241013-vchiq_arm-of_node_put-60a5eaaafd70

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

Posted by Dan Carpenter 1 month, 1 week ago

On Mon, Oct 14, 2024 at 10:56:35AM +0200, Javier Carrasco wrote:
> This series refactors some useless goto instructions as a preparation
> for the fix of a missing of_node_put() by means of the cleanup
> attribute.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Changes in v2:
> - Refactor vchiq_probe() to remove goto instructions.
> - Declare and initialize the node right before its first usage.
> - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter

Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

Posted by Umang Jain 1 month, 1 week ago

Hi Javier,

Thank you for the patch

On 14/10/24 2:26 pm, Javier Carrasco wrote:
> This series refactors some useless goto instructions as a preparation
> for the fix of a missing of_node_put() by means of the cleanup
> attribute.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

For the series,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> Changes in v2:
> - Refactor vchiq_probe() to remove goto instructions.
> - Declare and initialize the node right before its first usage.
> - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com
>
> ---
> Javier Carrasco (2):
>        staging: vchiq_arm: refactor goto instructions in vchiq_probe()
>        staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node
>
>   .../vc04_services/interface/vchiq_arm/vchiq_arm.c     | 19 +++++++------------
>   1 file changed, 7 insertions(+), 12 deletions(-)
> ---
> base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
> change-id: 20241013-vchiq_arm-of_node_put-60a5eaaafd70
>
> Best regards,