s390: two bugfixes (for kunit)

[PATCH 0/2] s390: two bugfixes (for kunit)

Posted by Thomas Weißschuh 1 month, 1 week ago

When trying to use kunit for s390 with
./tools/testing/kunit/kunit.py run --arch=s390 --kunitconfig drivers/base/test --cross_compile=$CROSS_COMPILE
I ran into some bugs.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
Thomas Weißschuh (2):
      s390/sclp: deactivate sclp after all its users
      s390/sclp_vt220: convert newlines to CRLF instead of LFCR

 drivers/s390/char/sclp.c       | 3 ++-
 drivers/s390/char/sclp_vt220.c | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: 6485cf5ea253d40d507cd71253c9568c5470cd27
change-id: 20241014-s390-kunit-47cbc26a99e6

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH 0/2] s390: two bugfixes (for kunit)

Posted by Heiko Carstens 1 month, 1 week ago

On Mon, Oct 14, 2024 at 07:50:05AM +0200, Thomas Weißschuh wrote:
> When trying to use kunit for s390 with
> ./tools/testing/kunit/kunit.py run --arch=s390 --kunitconfig drivers/base/test --cross_compile=$CROSS_COMPILE
> I ran into some bugs.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Thomas Weißschuh (2):
>       s390/sclp: deactivate sclp after all its users
>       s390/sclp_vt220: convert newlines to CRLF instead of LFCR
> 
>  drivers/s390/char/sclp.c       | 3 ++-
>  drivers/s390/char/sclp_vt220.c | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)

Applied, thanks!

Re: [PATCH 0/2] s390: two bugfixes (for kunit)

Posted by Sven Schnelle 1 month, 1 week ago

Thomas Weißschuh <thomas.weissschuh@linutronix.de> writes:

> When trying to use kunit for s390 with
> ./tools/testing/kunit/kunit.py run --arch=s390 --kunitconfig drivers/base/test --cross_compile=$CROSS_COMPILE
> I ran into some bugs.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Thomas Weißschuh (2):
>       s390/sclp: deactivate sclp after all its users
>       s390/sclp_vt220: convert newlines to CRLF instead of LFCR
>
>  drivers/s390/char/sclp.c       | 3 ++-
>  drivers/s390/char/sclp_vt220.c | 4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> ---
> base-commit: 6485cf5ea253d40d507cd71253c9568c5470cd27
> change-id: 20241014-s390-kunit-47cbc26a99e6

Looks good to me. For both patches:

Reviewed-by: Sven Schnelle <svens@linux.ibm.com>

Thanks!
Sven