[PATCH] firmware: tf: fix missing of_node_put() in of_register_trusted_foundation()

Javier Carrasco posted 1 patch 1 year, 2 months ago
drivers/firmware/trusted_foundations.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] firmware: tf: fix missing of_node_put() in of_register_trusted_foundation()
Posted by Javier Carrasco 1 year, 2 months ago
of_find_compatible_node() requires a call to of_node_put() when the
pointer to the node is not required anymore to decrement its refcount
and avoid leaking memory.

Add the missing call to of_node_put() after the node has been used.

Cc: stable@vger.kernel.org
Fixes: d9a1beaa10e8 ("ARM: add basic support for Trusted Foundations")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/firmware/trusted_foundations.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/trusted_foundations.c b/drivers/firmware/trusted_foundations.c
index 1389fa9418a7..e9fc79805c3e 100644
--- a/drivers/firmware/trusted_foundations.c
+++ b/drivers/firmware/trusted_foundations.c
@@ -175,6 +175,7 @@ void of_register_trusted_foundations(void)
 				   &pdata.version_minor);
 	if (err != 0)
 		panic("Trusted Foundation: missing version-minor property\n");
+	of_node_put(node);
 	register_trusted_foundations(&pdata);
 }
 

---
base-commit: d61a00525464bfc5fe92c6ad713350988e492b88
change-id: 20241013-trusted_foundations-of_node_put-4b905f3ba009

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>