[PATCH v2 0/8] misc: keba: Add support for additional devices

Gerhard Engleder posted 8 patches 1 month, 2 weeks ago
drivers/misc/keba/Kconfig   |  11 +
drivers/misc/keba/Makefile  |   1 +
drivers/misc/keba/cp500.c   | 558 ++++++++++++++++++++++++++++++++++--
drivers/misc/keba/lan9252.c | 359 +++++++++++++++++++++++
include/linux/misc/keba.h   |  47 +++
5 files changed, 955 insertions(+), 21 deletions(-)
create mode 100644 drivers/misc/keba/lan9252.c
[PATCH v2 0/8] misc: keba: Add support for additional devices
Posted by Gerhard Engleder 1 month, 2 weeks ago
Add SPI controller auxiliary device. The SPI controller driver is not
part of this series, because it should target spi-next and not
char-misc. Additionally a driver for the LAN9252 chip, which is
connected to the SPI controller, is included. This driver only
configures the LAN9252 chip in the right mode and provides no user space
interface.

The main EEPROM of the CP500 devices is divided into two sections by
design/factory. Therefore, provide the two section as separate NVMEM
devices.

Add fan, battery and UART auxiliary devices. Similar to the SPI
controller, this is some prepartion work, because the drivers will
target other branches than char-misc.

The series starts with two small cleanups.

v2:
- separate commits for clean up (Greg KH)
- uninitialized warning in lan9252_probe() for variable ret (kernel test robot)

Gerhard Engleder (8):
  misc: keba: Use variable ret for return values
  misc: keba: Use capital letters for I2C error message
  misc: keba: Add SPI controller device
  misc: keba: Add LAN9252 driver
  misc: keba: Support EEPROM sections as separate devices
  misc: keba: Add fan device
  misc: keba: Add battery device
  misc: keba: Add UART devices

 drivers/misc/keba/Kconfig   |  11 +
 drivers/misc/keba/Makefile  |   1 +
 drivers/misc/keba/cp500.c   | 558 ++++++++++++++++++++++++++++++++++--
 drivers/misc/keba/lan9252.c | 359 +++++++++++++++++++++++
 include/linux/misc/keba.h   |  47 +++
 5 files changed, 955 insertions(+), 21 deletions(-)
 create mode 100644 drivers/misc/keba/lan9252.c

-- 
2.39.2
Re: [PATCH v2 0/8] misc: keba: Add support for additional devices
Posted by Greg KH 1 month, 2 weeks ago
On Fri, Oct 11, 2024 at 09:12:49PM +0200, Gerhard Engleder wrote:
> Add SPI controller auxiliary device. The SPI controller driver is not
> part of this series, because it should target spi-next and not
> char-misc. Additionally a driver for the LAN9252 chip, which is
> connected to the SPI controller, is included. This driver only
> configures the LAN9252 chip in the right mode and provides no user space
> interface.
> 
> The main EEPROM of the CP500 devices is divided into two sections by
> design/factory. Therefore, provide the two section as separate NVMEM
> devices.
> 
> Add fan, battery and UART auxiliary devices. Similar to the SPI
> controller, this is some prepartion work, because the drivers will
> target other branches than char-misc.
> 
> The series starts with two small cleanups.
> 
> v2:
> - separate commits for clean up (Greg KH)

Ah, I wasn't saying "this must be done" at all, it was just a minor
comment.  But thanks for doing it!

greg k-h