1. Patchew
  2. linux
  3. [PATCH 0/4] Add support for APPS SMMU on QCS615
  4. View patch

[PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu

Qingqing Zhou posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu
Posted by Qingqing Zhou 1 month, 2 weeks ago 
Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function
is required by multiple functions including USB/UFS/Ethernet.

Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 92d350b8e01a..9e62c2cdda08 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -36,6 +36,7 @@ properties:
         items:
           - enum:
               - qcom,qcm2290-smmu-500
+              - qcom,qcs615-smmu-500
               - qcom,qcs8300-smmu-500
               - qcom,qdu1000-smmu-500
               - qcom,sa8255p-smmu-500
-- 
2.17.1
Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On 11/10/2024 08:31, Qingqing Zhou wrote:
> Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function
> is required by multiple functions including USB/UFS/Ethernet.

Do not explain what SMMU is, because it is obvious, but explain how this
hardware differs from everything existing.

> 
> Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com>
> ---
>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 92d350b8e01a..9e62c2cdda08 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -36,6 +36,7 @@ properties:
>          items:
>            - enum:
>                - qcom,qcm2290-smmu-500
> +              - qcom,qcs615-smmu-500

This is incomplete? No clocks? No power-domains?

Best regards,
Krzysztof
Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu
Posted by Qingqing Zhou 1 month, 2 weeks ago 

在 10/11/2024 2:48 PM, Krzysztof Kozlowski 写道:
> On 11/10/2024 08:31, Qingqing Zhou wrote:
>> Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function
>> is required by multiple functions including USB/UFS/Ethernet.
> 
> Do not explain what SMMU is, because it is obvious, but explain how this
> hardware differs from everything existing.
OK, will improve the comments in next patch version.
> 
>>
>> Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 92d350b8e01a..9e62c2cdda08 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -36,6 +36,7 @@ properties:
>>          items:
>>            - enum:
>>                - qcom,qcm2290-smmu-500
>> +              - qcom,qcs615-smmu-500
> 
> This is incomplete? No clocks? No power-domains?
This is APPS SMMU, no clocks and no power-domains are needed for DT.
> 
> Best regards,
> Krzysztof
>
Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On 14/10/2024 05:09, Qingqing Zhou wrote:
>>> ---
>>>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> index 92d350b8e01a..9e62c2cdda08 100644
>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>> @@ -36,6 +36,7 @@ properties:
>>>          items:
>>>            - enum:
>>>                - qcom,qcm2290-smmu-500
>>> +              - qcom,qcs615-smmu-500
>>
>> This is incomplete? No clocks? No power-domains?
> This is APPS SMMU, no clocks and no power-domains are needed for DT.

Then express it in the binding.

Best regards,
Krzysztof
Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu
Posted by Qingqing Zhou 1 month, 1 week ago 

在 10/14/2024 2:52 PM, Krzysztof Kozlowski 写道:
> On 14/10/2024 05:09, Qingqing Zhou wrote:
>>>> ---
>>>>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>>> index 92d350b8e01a..9e62c2cdda08 100644
>>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>>>> @@ -36,6 +36,7 @@ properties:
>>>>          items:
>>>>            - enum:
>>>>                - qcom,qcm2290-smmu-500
>>>> +              - qcom,qcs615-smmu-500
>>>
>>> This is incomplete? No clocks? No power-domains?
>> This is APPS SMMU, no clocks and no power-domains are needed for DT.
> 
> Then express it in the binding.
OK, will add this in next patch version.
> 
> Best regards,
> Krzysztof
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.