[PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition

Pengfei Li posted 3 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition
Posted by Pengfei Li 1 month, 2 weeks ago
i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
Add i.MX91 related clock definition.

Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 include/dt-bindings/clock/imx93-clock.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
index 787c9e74dc96..6c685067288b 100644
--- a/include/dt-bindings/clock/imx93-clock.h
+++ b/include/dt-bindings/clock/imx93-clock.h
@@ -204,6 +204,10 @@
 #define IMX93_CLK_A55_SEL		199
 #define IMX93_CLK_A55_CORE		200
 #define IMX93_CLK_PDM_IPG		201
-#define IMX93_CLK_END			202
+#define IMX91_CLK_ENET1_QOS_TSN     202
+#define IMX91_CLK_ENET_TIMER        203
+#define IMX91_CLK_ENET2_REGULAR     204
+#define IMX91_CLK_ENET2_REGULAR_GATE		205
+#define IMX91_CLK_ENET1_QOS_TSN_GATE		206
 
 #endif
-- 
2.34.1
Re: [PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition
Posted by Rob Herring 1 month, 2 weeks ago
On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote:
> i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
> Add i.MX91 related clock definition.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
>  include/dt-bindings/clock/imx93-clock.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

This belongs with the binding patch.

> 
> diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
> index 787c9e74dc96..6c685067288b 100644
> --- a/include/dt-bindings/clock/imx93-clock.h
> +++ b/include/dt-bindings/clock/imx93-clock.h
> @@ -204,6 +204,10 @@
>  #define IMX93_CLK_A55_SEL		199
>  #define IMX93_CLK_A55_CORE		200
>  #define IMX93_CLK_PDM_IPG		201
> -#define IMX93_CLK_END			202
> +#define IMX91_CLK_ENET1_QOS_TSN     202
> +#define IMX91_CLK_ENET_TIMER        203
> +#define IMX91_CLK_ENET2_REGULAR     204
> +#define IMX91_CLK_ENET2_REGULAR_GATE		205
> +#define IMX91_CLK_ENET1_QOS_TSN_GATE		206
>  
>  #endif
> -- 
> 2.34.1
>
Re: [PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote:
> i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
> Add i.MX91 related clock definition.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
>  include/dt-bindings/clock/imx93-clock.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
> index 787c9e74dc96..6c685067288b 100644
> --- a/include/dt-bindings/clock/imx93-clock.h
> +++ b/include/dt-bindings/clock/imx93-clock.h
> @@ -204,6 +204,10 @@
>  #define IMX93_CLK_A55_SEL		199
>  #define IMX93_CLK_A55_CORE		200
>  #define IMX93_CLK_PDM_IPG		201
> -#define IMX93_CLK_END			202

This is supposed to be separate patch, because you are removing
something from ABI.

If your maintainer NAKed it, then do not sneak it some other way. Sort
the problem with maintainer or entire patchset cannot enter.

Best regards,
Krzysztof
Re: [PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition
Posted by Rob Herring 1 month, 2 weeks ago
On Fri, Oct 11, 2024 at 04:40:35PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote:
> > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
> > Add i.MX91 related clock definition.
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  include/dt-bindings/clock/imx93-clock.h | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
> > index 787c9e74dc96..6c685067288b 100644
> > --- a/include/dt-bindings/clock/imx93-clock.h
> > +++ b/include/dt-bindings/clock/imx93-clock.h
> > @@ -204,6 +204,10 @@
> >  #define IMX93_CLK_A55_SEL		199
> >  #define IMX93_CLK_A55_CORE		200
> >  #define IMX93_CLK_PDM_IPG		201
> > -#define IMX93_CLK_END			202
> 
> This is supposed to be separate patch, because you are removing
> something from ABI.

But "end" defines are not part of the ABI.

> 
> If your maintainer NAKed it, then do not sneak it some other way. Sort
> the problem with maintainer or entire patchset cannot enter.
> 
> Best regards,
> Krzysztof
>