ALSA: core: Remove unused copy_from_user_toio

[PATCH] ALSA: core: Remove unused copy_from_user_toio

Posted by linux@treblig.org 1 year, 3 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

copy_from_user_toio() has been unused since commit
ce2d8ed8d809 ("ASoC: qcom: Convert to generic PCM copy ops")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/sound/core.h |  1 -
 sound/core/memory.c  | 20 --------------------
 2 files changed, 21 deletions(-)

diff --git a/include/sound/core.h b/include/sound/core.h
index 1f3f5dccd736..b5a6f3d2bff5 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -267,7 +267,6 @@ static inline int snd_minor_info_oss_init(void) { return 0; }
 /* memory.c */
 
 int copy_to_user_fromio(void __user *dst, const volatile void __iomem *src, size_t count);
-int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count);
 
 /* init.c */
 
diff --git a/sound/core/memory.c b/sound/core/memory.c
index 2d2d0094c897..8222a851da87 100644
--- a/sound/core/memory.c
+++ b/sound/core/memory.c
@@ -63,26 +63,6 @@ int copy_to_iter_fromio(struct iov_iter *dst, const void __iomem *src,
 }
 EXPORT_SYMBOL(copy_to_iter_fromio);
 
-/**
- * copy_from_user_toio - copy data from user-space to mmio-space
- * @dst: the destination pointer on mmio-space
- * @src: the source pointer on user-space
- * @count: the data size to copy in bytes
- *
- * Copies the data from user-space to mmio-space.
- *
- * Return: Zero if successful, or non-zero on failure.
- */
-int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count)
-{
-	struct iov_iter iter;
-
-	if (import_ubuf(ITER_SOURCE, (void __user *)src, count, &iter))
-		return -EFAULT;
-	return copy_from_iter_toio((void __iomem *)dst, &iter, count);
-}
-EXPORT_SYMBOL(copy_from_user_toio);
-
 /**
  * copy_from_iter_toio - copy data from iov_iter to mmio-space
  * @dst: the destination pointer on mmio-space
-- 
2.47.0

Re: [PATCH] ALSA: core: Remove unused copy_from_user_toio

Posted by Takashi Iwai 1 year, 3 months ago

On Thu, 10 Oct 2024 22:53:40 +0200,
linux@treblig.org wrote:
> 
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> copy_from_user_toio() has been unused since commit
> ce2d8ed8d809 ("ASoC: qcom: Convert to generic PCM copy ops")
> 
> Remove it.

It's a pair of copy_to_*(), so if any, it should be dropped only after
both users are gone.


thanks,

Takashi

> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  include/sound/core.h |  1 -
>  sound/core/memory.c  | 20 --------------------
>  2 files changed, 21 deletions(-)
> 
> diff --git a/include/sound/core.h b/include/sound/core.h
> index 1f3f5dccd736..b5a6f3d2bff5 100644
> --- a/include/sound/core.h
> +++ b/include/sound/core.h
> @@ -267,7 +267,6 @@ static inline int snd_minor_info_oss_init(void) { return 0; }
>  /* memory.c */
>  
>  int copy_to_user_fromio(void __user *dst, const volatile void __iomem *src, size_t count);
> -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count);
>  
>  /* init.c */
>  
> diff --git a/sound/core/memory.c b/sound/core/memory.c
> index 2d2d0094c897..8222a851da87 100644
> --- a/sound/core/memory.c
> +++ b/sound/core/memory.c
> @@ -63,26 +63,6 @@ int copy_to_iter_fromio(struct iov_iter *dst, const void __iomem *src,
>  }
>  EXPORT_SYMBOL(copy_to_iter_fromio);
>  
> -/**
> - * copy_from_user_toio - copy data from user-space to mmio-space
> - * @dst: the destination pointer on mmio-space
> - * @src: the source pointer on user-space
> - * @count: the data size to copy in bytes
> - *
> - * Copies the data from user-space to mmio-space.
> - *
> - * Return: Zero if successful, or non-zero on failure.
> - */
> -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count)
> -{
> -	struct iov_iter iter;
> -
> -	if (import_ubuf(ITER_SOURCE, (void __user *)src, count, &iter))
> -		return -EFAULT;
> -	return copy_from_iter_toio((void __iomem *)dst, &iter, count);
> -}
> -EXPORT_SYMBOL(copy_from_user_toio);
> -
>  /**
>   * copy_from_iter_toio - copy data from iov_iter to mmio-space
>   * @dst: the destination pointer on mmio-space
> -- 
> 2.47.0
>

Re: [PATCH] ALSA: core: Remove unused copy_from_user_toio

Posted by Dr. David Alan Gilbert 1 year, 3 months ago

* Takashi Iwai (tiwai@suse.de) wrote:
> On Thu, 10 Oct 2024 22:53:40 +0200,
> linux@treblig.org wrote:
> > 
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > copy_from_user_toio() has been unused since commit
> > ce2d8ed8d809 ("ASoC: qcom: Convert to generic PCM copy ops")
> > 
> > Remove it.
> 
> It's a pair of copy_to_*(), so if any, it should be dropped only after
> both users are gone.

OK, fair enough.

Dave

> 
> thanks,
> 
> Takashi
> 
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  include/sound/core.h |  1 -
> >  sound/core/memory.c  | 20 --------------------
> >  2 files changed, 21 deletions(-)
> > 
> > diff --git a/include/sound/core.h b/include/sound/core.h
> > index 1f3f5dccd736..b5a6f3d2bff5 100644
> > --- a/include/sound/core.h
> > +++ b/include/sound/core.h
> > @@ -267,7 +267,6 @@ static inline int snd_minor_info_oss_init(void) { return 0; }
> >  /* memory.c */
> >  
> >  int copy_to_user_fromio(void __user *dst, const volatile void __iomem *src, size_t count);
> > -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count);
> >  
> >  /* init.c */
> >  
> > diff --git a/sound/core/memory.c b/sound/core/memory.c
> > index 2d2d0094c897..8222a851da87 100644
> > --- a/sound/core/memory.c
> > +++ b/sound/core/memory.c
> > @@ -63,26 +63,6 @@ int copy_to_iter_fromio(struct iov_iter *dst, const void __iomem *src,
> >  }
> >  EXPORT_SYMBOL(copy_to_iter_fromio);
> >  
> > -/**
> > - * copy_from_user_toio - copy data from user-space to mmio-space
> > - * @dst: the destination pointer on mmio-space
> > - * @src: the source pointer on user-space
> > - * @count: the data size to copy in bytes
> > - *
> > - * Copies the data from user-space to mmio-space.
> > - *
> > - * Return: Zero if successful, or non-zero on failure.
> > - */
> > -int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count)
> > -{
> > -	struct iov_iter iter;
> > -
> > -	if (import_ubuf(ITER_SOURCE, (void __user *)src, count, &iter))
> > -		return -EFAULT;
> > -	return copy_from_iter_toio((void __iomem *)dst, &iter, count);
> > -}
> > -EXPORT_SYMBOL(copy_from_user_toio);
> > -
> >  /**
> >   * copy_from_iter_toio - copy data from iov_iter to mmio-space
> >   * @dst: the destination pointer on mmio-space
> > -- 
> > 2.47.0
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/