selftests: net/rds: add module not found

[PATCH v2] selftests: net/rds: add module not found

Posted by Alessandro Zanni 1 year, 4 months ago

This fix solves this error, when calling kselftest with targets "net/rds":

The error was found by running tests manually with the command:
make kselftest TARGETS="net/rds"

The patch also specifies to import ip() function from the utils module.

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---

Notes:
    v2:
      modified the way the parent path is added
      added test to reproduce the error

 tools/testing/selftests/net/rds/test.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py
index e6bb109bcead..4a7178d11193 100755
--- a/tools/testing/selftests/net/rds/test.py
+++ b/tools/testing/selftests/net/rds/test.py
@@ -14,8 +14,11 @@ import sys
 import atexit
 from pwd import getpwuid
 from os import stat
-from lib.py import ip
 
+# Allow utils module to be imported from different directory
+this_dir = os.path.dirname(os.path.realpath(__file__))
+sys.path.append(os.path.join(this_dir, "../"))
+from lib.py.utils import ip
 
 libc = ctypes.cdll.LoadLibrary('libc.so.6')
 setns = libc.setns
-- 
2.43.0

Re: [PATCH v2] selftests: net/rds: add module not found

Posted by Allison Henderson 1 year, 3 months ago

On Thu, 2024-10-10 at 21:44 +0200, Alessandro Zanni wrote:
> This fix solves this error, when calling kselftest with targets
> "net/rds":
> 
> The error was found by running tests manually with the command:
> make kselftest TARGETS="net/rds"
> 
> The patch also specifies to import ip() function from the utils
> module.
> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
I think this one looks ok.  Thanks Alessandro!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> 
> Notes:
>     v2:
>       modified the way the parent path is added
>       added test to reproduce the error
> 
>  tools/testing/selftests/net/rds/test.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rds/test.py
> b/tools/testing/selftests/net/rds/test.py
> index e6bb109bcead..4a7178d11193 100755
> --- a/tools/testing/selftests/net/rds/test.py
> +++ b/tools/testing/selftests/net/rds/test.py
> @@ -14,8 +14,11 @@ import sys
>  import atexit
>  from pwd import getpwuid
>  from os import stat
> -from lib.py import ip
>  
> +# Allow utils module to be imported from different directory
> +this_dir = os.path.dirname(os.path.realpath(__file__))
> +sys.path.append(os.path.join(this_dir, "../"))
> +from lib.py.utils import ip
>  
>  libc = ctypes.cdll.LoadLibrary('libc.so.6')
>  setns = libc.setns