arm64: dts: renesas: hihope: Drop #sound-dai-cells

[PATCH] arm64: dts: renesas: hihope: Drop #sound-dai-cells

Posted by Prabhakar 1 year, 4 months ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

`#sound-dai-cells` is required if board is using "simple-card", and on
the hihope board we are using "audio-graph" thus remove the unneeded
`#sound-dai-cells`.

Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when
simple-card") updated the comment regarding usage of `#sound-dai-cells`
in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS
files.

Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/hihope-rev2.dtsi | 3 ---
 arch/arm64/boot/dts/renesas/hihope-rev4.dtsi | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
index 8e2db1d6ca81..25c55b32aafe 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
@@ -69,9 +69,6 @@ &rcar_sound {
 
 	status = "okay";
 
-	/* Single DAI */
-	#sound-dai-cells = <0>;
-
 	rsnd_port: port {
 		rsnd_endpoint: endpoint {
 			remote-endpoint = <&dw_hdmi0_snd_in>;
diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
index 66f3affe0469..deb69c272775 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
@@ -84,9 +84,6 @@ &rcar_sound {
 	pinctrl-names = "default";
 	status = "okay";
 
-	/* Single DAI */
-	#sound-dai-cells = <0>;
-
 	/* audio_clkout0/1/2/3 */
 	#clock-cells = <1>;
 	clock-frequency = <12288000 11289600>;
-- 
2.43.0

Re: [PATCH] arm64: dts: renesas: hihope: Drop #sound-dai-cells

Posted by Geert Uytterhoeven 1 year, 3 months ago

CC morimoto-san

On Thu, Oct 10, 2024 at 3:53 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> `#sound-dai-cells` is required if board is using "simple-card", and on
> the hihope board we are using "audio-graph" thus remove the unneeded
> `#sound-dai-cells`.
>
> Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when
> simple-card") updated the comment regarding usage of `#sound-dai-cells`
> in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS
> files.
>
> Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13, unless Morimoto-san objects.

> diff --git a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> index 8e2db1d6ca81..25c55b32aafe 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> @@ -69,9 +69,6 @@ &rcar_sound {
>
>         status = "okay";
>
> -       /* Single DAI */
> -       #sound-dai-cells = <0>;
> -
>         rsnd_port: port {
>                 rsnd_endpoint: endpoint {
>                         remote-endpoint = <&dw_hdmi0_snd_in>;
> diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> index 66f3affe0469..deb69c272775 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> @@ -84,9 +84,6 @@ &rcar_sound {
>         pinctrl-names = "default";
>         status = "okay";
>
> -       /* Single DAI */
> -       #sound-dai-cells = <0>;
> -
>         /* audio_clkout0/1/2/3 */
>         #clock-cells = <1>;
>         clock-frequency = <12288000 11289600>;

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: hihope: Drop #sound-dai-cells

Posted by Kuninori Morimoto 1 year, 3 months ago

Hi

> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > `#sound-dai-cells` is required if board is using "simple-card", and on
> > the hihope board we are using "audio-graph" thus remove the unneeded
> > `#sound-dai-cells`.
> >
> > Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when
> > simple-card") updated the comment regarding usage of `#sound-dai-cells`
> > in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS
> > files.
> >
> > Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card")
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.13, unless Morimoto-san objects.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto