[PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call

Liu Ying posted 1 patch 1 month, 2 weeks ago
drivers/gpu/drm/bridge/ite-it66121.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call
Posted by Liu Ying 1 month, 2 weeks ago
drm_hdmi_avi_infoframe_from_display_mode() called from
it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to
initialize an HDMI AVI infoframe.  So, drop the redundant
hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set().

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/ite-it66121.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 925e42f46cd8..35ae3f0e8f51 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -770,8 +770,6 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge,
 
 	mutex_lock(&ctx->lock);
 
-	hdmi_avi_infoframe_init(&ctx->hdmi_avi_infoframe);
-
 	ret = drm_hdmi_avi_infoframe_from_display_mode(&ctx->hdmi_avi_infoframe, ctx->connector,
 						       adjusted_mode);
 	if (ret) {
-- 
2.34.1
Re: [PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call
Posted by Neil Armstrong 1 month ago
Hi,

On Thu, 10 Oct 2024 17:26:43 +0800, Liu Ying wrote:
> drm_hdmi_avi_infoframe_from_display_mode() called from
> it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to
> initialize an HDMI AVI infoframe.  So, drop the redundant
> hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set().
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c7671949791fb1142d0ae37343759d608a21bf28

-- 
Neil
Re: [PATCH] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call
Posted by Dmitry Baryshkov 1 month, 2 weeks ago
On Thu, Oct 10, 2024 at 05:26:43PM GMT, Liu Ying wrote:
> drm_hdmi_avi_infoframe_from_display_mode() called from
> it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to
> initialize an HDMI AVI infoframe.  So, drop the redundant
> hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set().
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry