selftests/bpf: Removed redundant variable

[PATCH] selftests/bpf: Removed redundant variable

Posted by Zhu Jun 1 month, 2 weeks ago

The error check is no longer needed for this test case,
simplifying the code.

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/testing/selftests/bpf/prog_tests/signal_pending.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/signal_pending.c b/tools/testing/selftests/bpf/prog_tests/signal_pending.c
index 70b49da5ca0a..8920fadb3aa9 100644
--- a/tools/testing/selftests/bpf/prog_tests/signal_pending.c
+++ b/tools/testing/selftests/bpf/prog_tests/signal_pending.c
@@ -36,7 +36,7 @@ static void test_signal_pending_by_type(enum bpf_prog_type prog_type)
 	err = setitimer(ITIMER_REAL, &timeo, NULL);
 	ASSERT_OK(err, "test-run-signal-timer");
 
-	err = bpf_prog_test_run_opts(prog_fd, &topts);
+	bpf_prog_test_run_opts(prog_fd, &topts);
 	ASSERT_LE(topts.duration, 500000000 /* 500ms */,
 		  "test-run-signal-duration");
 
-- 
2.17.1

Re: [PATCH] selftests/bpf: Removed redundant variable

Posted by Andrii Nakryiko 1 month, 2 weeks ago

On Wed, Oct 9, 2024 at 11:46 PM Zhu Jun <zhujun2@cmss.chinamobile.com> wrote:
>
> The error check is no longer needed for this test case,
> simplifying the code.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/signal_pending.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

please add bpf@vger.kernel.org and resend. Also use [PATCH bpf-next]
prefix for email subject.

> diff --git a/tools/testing/selftests/bpf/prog_tests/signal_pending.c b/tools/testing/selftests/bpf/prog_tests/signal_pending.c
> index 70b49da5ca0a..8920fadb3aa9 100644
> --- a/tools/testing/selftests/bpf/prog_tests/signal_pending.c
> +++ b/tools/testing/selftests/bpf/prog_tests/signal_pending.c
> @@ -36,7 +36,7 @@ static void test_signal_pending_by_type(enum bpf_prog_type prog_type)
>         err = setitimer(ITIMER_REAL, &timeo, NULL);
>         ASSERT_OK(err, "test-run-signal-timer");
>
> -       err = bpf_prog_test_run_opts(prog_fd, &topts);
> +       bpf_prog_test_run_opts(prog_fd, &topts);
>         ASSERT_LE(topts.duration, 500000000 /* 500ms */,
>                   "test-run-signal-duration");
>
> --
> 2.17.1
>
>
>