[PATCH v2] arm64: defconfig: Enable WCD937x driver as module

Mohammad Rafi Shaik posted 1 patch 1 month, 2 weeks ago
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2] arm64: defconfig: Enable WCD937x driver as module
Posted by Mohammad Rafi Shaik 1 month, 2 weeks ago
Enable Qualcomm WCD937x codec driver as modules
since it is now used on the QCM6490 platform.

Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Reviewed-by: Rohit Kumar <quic_rohkumar@quicinc.com>
---
Changes in v2:
- Rephrase the commit message as suggested by Trilok Soni.
- Link to v1: https://lore.kernel.org/linux-arm-kernel/6cabe8cf-7286-22f8-029f-140b084004e1@quicinc.com/
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5fdbfea7a5b2..c4746e3412f8 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1036,6 +1036,8 @@ CONFIG_SND_SOC_TLV320AIC32X4_I2C=m
 CONFIG_SND_SOC_TLV320AIC3X_I2C=m
 CONFIG_SND_SOC_WCD9335=m
 CONFIG_SND_SOC_WCD934X=m
+CONFIG_SND_SOC_WCD937X=m
+CONFIG_SND_SOC_WCD937X_SDW=m
 CONFIG_SND_SOC_WCD939X=m
 CONFIG_SND_SOC_WCD939X_SDW=m
 CONFIG_SND_SOC_WM8524=m
-- 
2.25.1
Re: [PATCH v2] arm64: defconfig: Enable WCD937x driver as module
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 10/10/2024 07:26, Mohammad Rafi Shaik wrote:
> Enable Qualcomm WCD937x codec driver as modules
> since it is now used on the QCM6490 platform.

QCM6490 is an SoC. Which company? That's a shared defconfig, you must be
here specific for which product you are making it.

Which upstream board uses it? Name it (fully) here as well. We add
things to defconfig for the boards, not for the SoCs. You cannot boot an
SoC.

> 
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Reviewed-by: Rohit Kumar <quic_rohkumar@quicinc.com>

No one will pick it up... You must Cc your SoC maintainers and mailing
lists, so they will see it and have in their queue/Patchwork.

Run get_maintainers on the SoC you are interested in.

Best regards,
Krzysztof
Re: [PATCH v2] arm64: defconfig: Enable WCD937x driver as module
Posted by Mohammad Rafi Shaik 1 month, 2 weeks ago
On 10/10/2024 11:15 AM, Krzysztof Kozlowski wrote:
> On 10/10/2024 07:26, Mohammad Rafi Shaik wrote:
>> Enable Qualcomm WCD937x codec driver as modules
>> since it is now used on the QCM6490 platform.
> 
> QCM6490 is an SoC. Which company? That's a shared defconfig, you must be
> here specific for which product you are making it.
> 
> Which upstream board uses it? Name it (fully) here as well. We add
> things to defconfig for the boards, not for the SoCs. You cannot boot an
> SoC.
> 
Ack, Will update the commit message.

The WCD937x codec now used in Qualcomm QCM6490 IDP board.

>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Reviewed-by: Rohit Kumar <quic_rohkumar@quicinc.com>
> 
> No one will pick it up... You must Cc your SoC maintainers and mailing
> lists, so they will see it and have in their queue/Patchwork.
> 
> Run get_maintainers on the SoC you are interested in.
> Ack,

Thanks and Regards,
Rafi.

> Best regards,
> Krzysztof
>