1. Patchew
  2. linux
  3. [PATCH 0/3] Add ethernet dts schema for qcs615/qcs8300
  4. View patch

[PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

Yijie Yang posted 3 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Posted by Yijie Yang 1 month, 2 weeks ago 
Add compatible for the MAC controller on qcs8300 platforms.
Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
compatible.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
 Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 8cf29493b822..3ee5367bdde1 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -23,6 +23,10 @@ properties:
           - enum:
               - qcom,qcs615-ethqos
           - const: qcom,sm8150-ethqos
+      - items:
+          - enum:
+              - qcom,qcs8300-ethqos
+          - const: qcom,sa8775p-ethqos
       - enum:
           - qcom,qcs404-ethqos
           - qcom,sa8775p-ethqos

-- 
2.34.1
Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
> Add compatible for the MAC controller on qcs8300 platforms.
> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
> compatible.
> 
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 8cf29493b822..3ee5367bdde1 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -23,6 +23,10 @@ properties:
>            - enum:
>                - qcom,qcs615-ethqos
>            - const: qcom,sm8150-ethqos
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-ethqos
> +          - const: qcom,sa8775p-ethqos

This block should go before earlier qcs615, to keep order by fallback.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Posted by Yijie Yang 1 month, 1 week ago 

On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>> Add compatible for the MAC controller on qcs8300 platforms.
>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>> compatible.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> index 8cf29493b822..3ee5367bdde1 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> @@ -23,6 +23,10 @@ properties:
>>             - enum:
>>                 - qcom,qcs615-ethqos
>>             - const: qcom,sm8150-ethqos
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-ethqos
>> +          - const: qcom,sa8775p-ethqos
> 
> This block should go before earlier qcs615, to keep order by fallback.

Why this block should positioned before qcs615, given that it comes 
later in alphabetical order?

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Posted by Krzysztof Kozlowski 1 month, 1 week ago 
On 15/10/2024 08:21, Yijie Yang wrote:
> 
> 
> On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>>> Add compatible for the MAC controller on qcs8300 platforms.
>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>>> compatible.
>>>
>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> index 8cf29493b822..3ee5367bdde1 100644
>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> @@ -23,6 +23,10 @@ properties:
>>>             - enum:
>>>                 - qcom,qcs615-ethqos
>>>             - const: qcom,sm8150-ethqos
>>> +      - items:
>>> +          - enum:
>>> +              - qcom,qcs8300-ethqos
>>> +          - const: qcom,sa8775p-ethqos
>>
>> This block should go before earlier qcs615, to keep order by fallback.

--------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^

Here

> 
> Why this block should positioned before qcs615, given that it comes 
> later in alphabetical order?

sa < sm

Best regards,
Krzysztof
Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300
Posted by Yijie Yang 1 month, 1 week ago 

On 2024-10-15 14:27, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:21, Yijie Yang wrote:
>>
>>
>> On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>>>> Add compatible for the MAC controller on qcs8300 platforms.
>>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>>>> compatible.
>>>>
>>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> index 8cf29493b822..3ee5367bdde1 100644
>>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> @@ -23,6 +23,10 @@ properties:
>>>>              - enum:
>>>>                  - qcom,qcs615-ethqos
>>>>              - const: qcom,sm8150-ethqos
>>>> +      - items:
>>>> +          - enum:
>>>> +              - qcom,qcs8300-ethqos
>>>> +          - const: qcom,sa8775p-ethqos
>>>
>>> This block should go before earlier qcs615, to keep order by fallback.
> 
> --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^
> 
> Here
> 
>>
>> Why this block should positioned before qcs615, given that it comes
>> later in alphabetical order?
> 
> sa < sm

Understood, thanks.

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Yijie

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.