Add compatibles string for the Sophgo SG2044 uarts.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml          | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index 4cdb0dcaccf3..6963f89a1848 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -58,6 +58,10 @@ properties:
               - brcm,bcm11351-dw-apb-uart
               - brcm,bcm21664-dw-apb-uart
           - const: snps,dw-apb-uart
+      - items:
+          - enum:
+              - sophgo,sg2044-uart
+          - const: snps,dw-apb-uart
       - items:
           - enum:
               - starfive,jh7100-hsuart
-- 
2.47.0

On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote:
> Add compatibles string for the Sophgo SG2044 uarts.

This we see from the diff, say something about hardware.

> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml          | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 4cdb0dcaccf3..6963f89a1848 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -58,6 +58,10 @@ properties:
>                - brcm,bcm11351-dw-apb-uart
>                - brcm,bcm21664-dw-apb-uart
>            - const: snps,dw-apb-uart
> +      - items:
> +          - enum:
> +              - sophgo,sg2044-uart

I would just add it to starfive enum, but this is fine as well.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote:
> > Add compatibles string for the Sophgo SG2044 uarts.
> 
> This we see from the diff, say something about hardware.
> 

The reason for this compatiable (and the hardware) is mainly in the
next patch. Will it be better to submit a new verion with improved
description? If so, I wonder whether I can reserve your ack.

> > 
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> >  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml          | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > index 4cdb0dcaccf3..6963f89a1848 100644
> > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > @@ -58,6 +58,10 @@ properties:
> >                - brcm,bcm11351-dw-apb-uart
> >                - brcm,bcm21664-dw-apb-uart
> >            - const: snps,dw-apb-uart
> > +      - items:
> > +          - enum:
> > +              - sophgo,sg2044-uart
> 
> I would just add it to starfive enum, but this is fine as well.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Thanks.

Regard,
Inochi

On Thu, Oct 10, 2024 at 04:23:05PM +0800, Inochi Amaoto wrote:
> On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote:
> > On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote:
> > > Add compatibles string for the Sophgo SG2044 uarts.
> > 
> > This we see from the diff, say something about hardware.
> 
> The reason for this compatiable (and the hardware) is mainly in the
> next patch. Will it be better to submit a new verion with improved
> description? If so, I wonder whether I can reserve your ack.
> 
> > I would just add it to starfive enum, but this is fine as well.

Even after reading the second patch I don't understand why you shouldn't re-use
the starfive compatible or make a new one that covers this quirk? At least I would
see that as second patch is basically not needed.

-- 
With Best Regards,
Andy Shevchenko

On Thu, Oct 10, 2024 at 05:54:48PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 04:23:05PM +0800, Inochi Amaoto wrote:
> > On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote:
> > > On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote:
> > > > Add compatibles string for the Sophgo SG2044 uarts.
> > > 
> > > This we see from the diff, say something about hardware.
> > 
> > The reason for this compatiable (and the hardware) is mainly in the
> > next patch. Will it be better to submit a new verion with improved
> > description? If so, I wonder whether I can reserve your ack.
> > 
> > > I would just add it to starfive enum, but this is fine as well.
> 
> Even after reading the second patch I don't understand why you shouldn't re-use
> the starfive compatible or make a new one that covers this quirk? At least I would
> see that as second patch is basically not needed.
> 

I do not think it is good to re-use the starfive compatible, it is weird
that a sophgo SoC has a peripheral on the statfive SoC. Another suggestion
for adding a new one that covers the quirk is a good idea for me, but I am
not sure whether it may cause some misunderstanding like reuse the starfive
compatible. If the second one is possible, it is OK for me to drop the second
patch.

Regard,
Inochi